Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(react): update number input tests #11804

Merged

Conversation

joshblack
Copy link
Contributor

Closes #11729

Update NumberInput and NumberInputSkeleton to use RTL. This also moves files under next to stable.

Changelog

New

Changed

  • Move files from NumberInput/next to NumberInput
  • Update NumberInput tests to RTL
  • Update NumberInputSkeleton tests to RTL

Removed

@joshblack joshblack requested review from a team as code owners July 14, 2022 16:03
@joshblack joshblack requested review from jnm2377 and dakahn July 14, 2022 16:03
@netlify
Copy link

netlify bot commented Jul 14, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0d70137
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/62e829194a9fef000942ee96
😎 Deploy Preview https://deploy-preview-11804--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jul 14, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 0d70137
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/62e82919db6c600008ceec57
😎 Deploy Preview https://deploy-preview-11804--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodiakhq kodiakhq bot merged commit f22522b into carbon-design-system:main Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Use RTL for testing in NumberInput/NumberInput-test.js
6 participants