Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Dropdown): update Dropdown controls and add playground #11799

Merged
merged 6 commits into from
Jul 28, 2022

Conversation

dakahn
Copy link
Contributor

@dakahn dakahn commented Jul 13, 2022

Closes #11717

Updates Dropdown Storybook and adds Playground controls

@dakahn dakahn requested a review from a team as a code owner July 13, 2022 23:01
@dakahn dakahn requested review from tw15egan and aledavila July 13, 2022 23:01
@netlify
Copy link

netlify bot commented Jul 13, 2022

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 4cb6e05
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/62e1d8fc3a2c490008ccd30d
😎 Deploy Preview https://deploy-preview-11799--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jul 13, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 4cb6e05
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/62e1d8fcd8925d0008af2c0d
😎 Deploy Preview https://deploy-preview-11799--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@aledavila aledavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the mdx file could you change components-dropdown--default to components-dropdown--playground just so that the code shows. Only in the first example.

packages/react/src/components/Dropdown/Dropdown.stories.js Outdated Show resolved Hide resolved
@dakahn dakahn requested review from aledavila and tw15egan July 14, 2022 23:36
@kodiakhq kodiakhq bot merged commit 6cd9dcb into main Jul 28, 2022
@kodiakhq kodiakhq bot deleted the 11717-update-dropdown-story-controls branch July 28, 2022 00:49
kennylam pushed a commit to kennylam/carbon that referenced this pull request Jul 30, 2024
…11799)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [sass](https://togithub.com/sass/dart-sass) | [`~1.76.0` -> `~1.77.0`](https://renovatebot.com/diffs/npm/sass/1.76.0/1.77.2) | [![age](https://developer.mend.io/api/mc/badges/age/npm/sass/1.77.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/sass/1.77.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/sass/1.76.0/1.77.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/sass/1.76.0/1.77.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>sass/dart-sass (sass)</summary>

### [`v1.77.2`](https://togithub.com/sass/dart-sass/blob/HEAD/CHANGELOG.md#1772)

[Compare Source](https://togithub.com/sass/dart-sass/compare/1.77.1...1.77.2)

-   Don't emit deprecation warnings for functions and mixins beginning with `__`.

-   Allow user-defined functions whose names begin with `_` and otherwise look
    like vendor-prefixed functions with special CSS syntax.

##### Command-Line Interface

-   Properly handle the `--silence-deprecation` flag.

-   Handle the `--fatal-deprecation` and `--future-deprecation` flags for
    `--interactive` mode.

### [`v1.77.1`](https://togithub.com/sass/dart-sass/blob/HEAD/CHANGELOG.md#1771)

[Compare Source](https://togithub.com/sass/dart-sass/compare/1.77.0...1.77.1)

-   Fix a crash that could come up with importers in certain contexts.

### [`v1.77.0`](https://togithub.com/sass/dart-sass/blob/HEAD/CHANGELOG.md#1770)

[Compare Source](https://togithub.com/sass/dart-sass/compare/1.76.0...1.77.0)

-   *Don't* throw errors for at-rules in keyframe blocks.

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Never, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/carbon-design-system/carbon-for-ibm-dotcom).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjMuNSIsInVwZGF0ZWRJblZlciI6IjM3LjM2My41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Ensure Dropdown-story.js has working controls
4 participants