Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-v10): add input change callback to multiselect filterable #11690

Merged
merged 2 commits into from
Jun 27, 2022
Merged

feat(react-v10): add input change callback to multiselect filterable #11690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5af8f9
feat(react): added input change callback to multiselect filterable (#…
TannerS May 17, 2022
c4ff2ce
chore(project): update caniuse-lite, browserslist db
tay1orjones Jun 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file removed .yarn/cache/caniuse-lite-npm-1.0.30001287-7c4995ce2e-b53c26a3a2.zip
View file
Open in desktop
Binary file not shown.
Binary file added .yarn/cache/caniuse-lite-npm-1.0.30001359-a30b134aa2-e15dbf4ea4.zip
View file
Open in desktop
Binary file not shown.
6 changes: 6 additions & 0 deletions packages/react/__tests__/__snapshots__/PublicAPI-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3083,6 +3083,9 @@ Map {
"onChange": Object {
"type": "func",
},
"onInputValueChange": Object {
"type": "func",
},
"onMenuChange": Object {
"type": "func",
},
Expand Down Expand Up @@ -4160,6 +4163,9 @@ Map {
"onChange": Object {
"type": "func",
},
"onInputValueChange": Object {
"type": "func",
},
"onMenuChange": Object {
"type": "func",
},
Expand Down
10 changes: 10 additions & 0 deletions packages/react/src/components/MultiSelect/FilterableMultiSelect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,12 @@ export default class FilterableMultiSelect extends React.Component {
*/
onChange: PropTypes.func,

/**
* `onInputValueChange` is a utility for this controlled component to communicate to
* the currently typed input.
*/
onInputValueChange: PropTypes.func,

/**
* `onMenuChange` is a utility for this controlled component to communicate to a
* consuming component that the menu was opened(`true`)/closed(`false`).
Expand Down Expand Up @@ -260,6 +266,10 @@ export default class FilterableMultiSelect extends React.Component {
};

handleOnInputValueChange = (inputValue, { type }) => {
if (this.props.onInputValueChange) {
this.props.onInputValueChange(inputValue);
}

if (type !== Downshift.stateChangeTypes.changeInput) {
return;
}
Expand Down
11 changes: 11 additions & 0 deletions packages/react/src/components/MultiSelect/next/FilterableMultiSelect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ const FilterableMultiSelect = React.forwardRef(function FilterableMultiSelect(
itemToString,
light,
locale,
onInputValueChange,
open,
onChange,
onMenuChange,
Expand Down Expand Up @@ -166,6 +167,10 @@ const FilterableMultiSelect = React.forwardRef(function FilterableMultiSelect(
}

function handleOnInputValueChange(inputValue, { type }) {
if (onInputValueChange) {
onInputValueChange(inputValue);
}

if (type !== Downshift.stateChangeTypes.changeInput) {
return;
}
Expand Down Expand Up @@ -516,6 +521,12 @@ FilterableMultiSelect.propTypes = {
*/
onChange: PropTypes.func,

/**
* `onInputValueChange` is a utility for this controlled component to communicate to
* the currently typed input.
*/
onInputValueChange: PropTypes.func,

/**
* `onMenuChange` is a utility for this controlled component to communicate to a
* consuming component that the menu was opened(`true`)/closed(`false`).
Expand Down
6 changes: 3 additions & 3 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11591,9 +11591,9 @@ __metadata:
linkType: hard

"caniuse-lite@npm:^1.0.0, caniuse-lite@npm:^1.0.30001109, caniuse-lite@npm:^1.0.30001125, caniuse-lite@npm:^1.0.30001179, caniuse-lite@npm:^1.0.30001202, caniuse-lite@npm:^1.0.30001219, caniuse-lite@npm:^1.0.30001228, caniuse-lite@npm:^1.0.30001272, caniuse-lite@npm:^1.0.30001286, caniuse-lite@npm:^1.0.30001287":
version: 1.0.30001287
resolution: "caniuse-lite@npm:1.0.30001287"
checksum: b53c26a3a267a2920394e4aa5d1f60a76f891943914068066700e5497dda512f096d8a77dfefda17306a9df06e16ce9c6b5179f8856cc0efbcd8873d13b2fbea
version: 1.0.30001359
resolution: "caniuse-lite@npm:1.0.30001359"
checksum: e15dbf4ea445367e998ad525c54620275ae382446d0bc289d14bf014a159074a2207881b46406b011a72676686f8a734457ea8e8d4856dc3f700c3391e89b43e
languageName: node
linkType: hard

Expand Down