Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui-shell): update ui shell tests to use testing library #11624

Conversation

joshblack
Copy link
Contributor

Closes #11558

This PR updates our UI Shell components to use testing library

Changelog

New

Changed

  • Content
  • Header
  • HeaderContainer
  • HeaderGlobalAction
  • HeaderGlobalBar
  • HeaderMenu
  • HeaderMenuButton
  • HeaderMenuItem
  • HeaderName
  • HeaderNavigation
  • Link
  • SideNav
  • SideNavDetails
  • SideNavFooter
  • SideNavHeader
  • SideNavIcon
  • SideNavItem
  • SideNavItems
  • SideNavLink
  • SideNavLinkText
  • SideNavMenu
  • SideNavMenuItem
  • SideNavSwitcher
  • SkipToContent

Testing / Reviewing

  • Verify all tests use React testing library
  • Verify tests use our test conventions with RTL

@joshblack joshblack requested a review from a team as a code owner June 16, 2022 18:23
@netlify
Copy link

netlify bot commented Jun 16, 2022

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 6a01538
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/62ab75357c39720009ef84e5
😎 Deploy Preview https://deploy-preview-11624--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 16, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 6a01538
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/62ab7535e3634f00091bf302
😎 Deploy Preview https://deploy-preview-11624--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 16, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 59ee5ca
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/62b23686e08fce0009e317ca
😎 Deploy Preview https://deploy-preview-11624--carbon-components-react.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 16, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 59ee5ca
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/62b236868e140e0008df1697
😎 Deploy Preview https://deploy-preview-11624--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once snapshots are updated

@joshblack joshblack requested a review from a team as a code owner June 21, 2022 15:24
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 🎉

@kodiakhq kodiakhq bot merged commit 4cb3f0e into carbon-design-system:main Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use RTL for testing in all UI Shell components
3 participants