test(react): update stories to fix failing avt #11620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshblack
approved these changes
Jun 15, 2022
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
dakahn
reviewed
Jun 16, 2022
| @@ -10,7 +10,7 @@ | |||
| const path = require('path'); | |||
|
|
|||
| module.exports = { | |||
| ruleArchive: 'latest', | |||
| ruleArchive: '09June2022', | |||
There was a problem hiding this comment.
we can't use latest anymore? is this an update on their end?
There was a problem hiding this comment.
@dakahn I think when we use latest we run into an issue where the ruleset may change and PRs start failing all of a sudden, even with no related change 😞
One idea was to specify the archive and then we update to the latest archive as they get released. This way, we can still stay up to date but not have to worry about our AVT job being flaky / failing unexpectedly.
dakahn
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
accessibility-checkerand resolves a violation that was showing up in some stories (but not the component itself, that seems to be good)Testing / Reviewing
Make sure AVT ci check passes