fix: add title to clear button for Search #11454
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DCO Assistant Lite bot: Thanks for your submission! We ask that you all sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. 1 out of 2 committers have signed the DCO. |
|
I have read the DCO document and I hereby sign the DCO. |
|
recheck |
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
I'll set up my ibm github and make a new pr |
kennylam
pushed a commit
to kennylam/carbon
that referenced
this pull request
Jul 30, 2024
…gn-system#11454) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@carbon/icons](https://togithub.com/carbon-design-system/carbon) ([source](https://togithub.com/carbon-design-system/carbon/tree/HEAD/packages/icons)) | [`11.34.0` -> `11.34.1`](https://renovatebot.com/diffs/npm/@carbon%2ficons/11.34.0/11.34.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>carbon-design-system/carbon (@&carbon-design-system#8203;carbon/icons)</summary> ### [`v11.34.1`](https://togithub.com/carbon-design-system/carbon/releases/tag/v11.34.1) [Compare Source](https://togithub.com/carbon-design-system/carbon/compare/v11.34.0...v11.34.1) ##### `[email protected]` ##### Housekeeping 🏠 - chore(release): v11.34.1 ([`22b28f5d0`](https://togithub.com/carbon-design-system/carbon/commit/22b28f5d0)) - chore(release): v11.34.0 ([#&carbon-design-system#8203;14282](https://togithub.com/carbon-design-system/carbon/issues/14282)) ([`42cf1b925`](https://togithub.com/carbon-design-system/carbon/commit/42cf1b925)) - chore(release): v11.34.0 ([`92d86277f`](https://togithub.com/carbon-design-system/carbon/commit/92d86277f)) ##### `[email protected]` ##### Housekeeping 🏠 - chore(release): v11.34.1 ([`22b28f5d0`](https://togithub.com/carbon-design-system/carbon/commit/22b28f5d0)) - chore(release): v11.34.0 ([#&carbon-design-system#8203;14282](https://togithub.com/carbon-design-system/carbon/issues/14282)) ([`42cf1b925`](https://togithub.com/carbon-design-system/carbon/commit/42cf1b925)) - chore(release): v11.34.0 ([`92d86277f`](https://togithub.com/carbon-design-system/carbon/commit/92d86277f)) ##### `[email protected]` ##### Housekeeping 🏠 - chore(release): v11.34.1 ([`22b28f5d0`](https://togithub.com/carbon-design-system/carbon/commit/22b28f5d0)) - chore(release): v11.34.0 ([#&carbon-design-system#8203;14282](https://togithub.com/carbon-design-system/carbon/issues/14282)) ([`42cf1b925`](https://togithub.com/carbon-design-system/carbon/commit/42cf1b925)) - chore(release): v11.34.0 ([`92d86277f`](https://togithub.com/carbon-design-system/carbon/commit/92d86277f)) ##### `@carbon/[email protected]` ##### Housekeeping 🏠 - chore(release): v11.34.1 ([`22b28f5d0`](https://togithub.com/carbon-design-system/carbon/commit/22b28f5d0)) - chore(release): v11.34.0 ([#&carbon-design-system#8203;14282](https://togithub.com/carbon-design-system/carbon/issues/14282)) ([`42cf1b925`](https://togithub.com/carbon-design-system/carbon/commit/42cf1b925)) - chore(release): v11.34.0 ([`92d86277f`](https://togithub.com/carbon-design-system/carbon/commit/92d86277f)) ##### `@carbon/[email protected]` ##### Housekeeping 🏠 - chore(release): v11.34.1 ([`22b28f5d0`](https://togithub.com/carbon-design-system/carbon/commit/22b28f5d0)) - chore(release): v11.34.0 ([#&carbon-design-system#8203;14282](https://togithub.com/carbon-design-system/carbon/issues/14282)) ([`42cf1b925`](https://togithub.com/carbon-design-system/carbon/commit/42cf1b925)) - chore(release): v11.34.0 ([`92d86277f`](https://togithub.com/carbon-design-system/carbon/commit/92d86277f)) ##### `@carbon/[email protected]` ##### Housekeeping 🏠 - chore(release): v11.34.1 ([`22b28f5d0`](https://togithub.com/carbon-design-system/carbon/commit/22b28f5d0)) - chore(release): v11.34.0 ([#&carbon-design-system#8203;14282](https://togithub.com/carbon-design-system/carbon/issues/14282)) ([`42cf1b925`](https://togithub.com/carbon-design-system/carbon/commit/42cf1b925)) - chore(release): v11.34.0 ([`92d86277f`](https://togithub.com/carbon-design-system/carbon/commit/92d86277f)) ##### `@carbon/[email protected]` ##### Housekeeping 🏠 - chore(release): v11.34.1 ([`22b28f5d0`](https://togithub.com/carbon-design-system/carbon/commit/22b28f5d0)) - chore(release): v11.34.0 ([#&carbon-design-system#8203;14282](https://togithub.com/carbon-design-system/carbon/issues/14282)) ([`42cf1b925`](https://togithub.com/carbon-design-system/carbon/commit/42cf1b925)) - chore(release): v11.34.0 ([`92d86277f`](https://togithub.com/carbon-design-system/carbon/commit/92d86277f)) ##### `@carbon/[email protected]` ##### Housekeeping 🏠 - chore(release): v11.34.1 ([`22b28f5d0`](https://togithub.com/carbon-design-system/carbon/commit/22b28f5d0)) - chore(release): v11.34.0 ([#&carbon-design-system#8203;14282](https://togithub.com/carbon-design-system/carbon/issues/14282)) ([`42cf1b925`](https://togithub.com/carbon-design-system/carbon/commit/42cf1b925)) - chore(release): v11.34.0 ([`92d86277f`](https://togithub.com/carbon-design-system/carbon/commit/92d86277f)) ##### `@carbon/[email protected]` ##### Housekeeping 🏠 - chore(release): v11.34.1 ([`22b28f5d0`](https://togithub.com/carbon-design-system/carbon/commit/22b28f5d0)) - chore(release): v11.34.0 ([#&carbon-design-system#8203;14282](https://togithub.com/carbon-design-system/carbon/issues/14282)) ([`42cf1b925`](https://togithub.com/carbon-design-system/carbon/commit/42cf1b925)) - chore(release): v11.34.0 ([`92d86277f`](https://togithub.com/carbon-design-system/carbon/commit/92d86277f)) ##### `@carbon/[email protected]` ##### Housekeeping 🏠 - chore(release): v11.34.1 ([`22b28f5d0`](https://togithub.com/carbon-design-system/carbon/commit/22b28f5d0)) - chore(release): v11.34.0 ([#&carbon-design-system#8203;14282](https://togithub.com/carbon-design-system/carbon/issues/14282)) ([`42cf1b925`](https://togithub.com/carbon-design-system/carbon/commit/42cf1b925)) - chore(release): v11.34.0 ([`92d86277f`](https://togithub.com/carbon-design-system/carbon/commit/92d86277f)) ##### `@carbon/[email protected]` ##### Housekeeping 🏠 - chore(release): v11.34.1 ([`22b28f5d0`](https://togithub.com/carbon-design-system/carbon/commit/22b28f5d0)) - chore(release): v11.34.0 ([#&carbon-design-system#8203;14282](https://togithub.com/carbon-design-system/carbon/issues/14282)) ([`42cf1b925`](https://togithub.com/carbon-design-system/carbon/commit/42cf1b925)) - chore(release): v11.34.0 ([`92d86277f`](https://togithub.com/carbon-design-system/carbon/commit/92d86277f)) ##### `@carbon/[email protected]` ##### Housekeeping 🏠 - chore(release): v11.34.1 ([`22b28f5d0`](https://togithub.com/carbon-design-system/carbon/commit/22b28f5d0)) - chore(release): v11.34.0 ([#&carbon-design-system#8203;14282](https://togithub.com/carbon-design-system/carbon/issues/14282)) ([`42cf1b925`](https://togithub.com/carbon-design-system/carbon/commit/42cf1b925)) - chore(release): v11.34.0 ([`92d86277f`](https://togithub.com/carbon-design-system/carbon/commit/92d86277f)) ##### `@carbon/[email protected]` ##### Housekeeping 🏠 - chore(release): v11.34.1 ([`22b28f5d0`](https://togithub.com/carbon-design-system/carbon/commit/22b28f5d0)) - chore(release): v11.34.0 ([#&carbon-design-system#8203;14282](https://togithub.com/carbon-design-system/carbon/issues/14282)) ([`42cf1b925`](https://togithub.com/carbon-design-system/carbon/commit/42cf1b925)) - chore(release): v11.34.0 ([`92d86277f`](https://togithub.com/carbon-design-system/carbon/commit/92d86277f)) ##### `@carbon/[email protected]` ##### Housekeeping 🏠 - chore(release): v11.34.1 ([`22b28f5d0`](https://togithub.com/carbon-design-system/carbon/commit/22b28f5d0)) - chore(release): v11.34.0 ([#&carbon-design-system#8203;14282](https://togithub.com/carbon-design-system/carbon/issues/14282)) ([`42cf1b925`](https://togithub.com/carbon-design-system/carbon/commit/42cf1b925)) - chore(release): v11.34.0 ([`92d86277f`](https://togithub.com/carbon-design-system/carbon/commit/92d86277f)) ##### `@carbon/[email protected]` ##### Housekeeping 🏠 - chore(release): v11.34.1 ([`22b28f5d0`](https://togithub.com/carbon-design-system/carbon/commit/22b28f5d0)) - chore(release): v11.34.0 ([#&carbon-design-system#8203;14282](https://togithub.com/carbon-design-system/carbon/issues/14282)) ([`42cf1b925`](https://togithub.com/carbon-design-system/carbon/commit/42cf1b925)) - chore(release): v11.34.0 ([`92d86277f`](https://togithub.com/carbon-design-system/carbon/commit/92d86277f)) ##### `@carbon/[email protected]` ##### Bug fixes 🐛 - fix(button): update imports to use the default export instead of named ([#&carbon-design-system#8203;14301](https://togithub.com/carbon-design-system/carbon/issues/14301)) ([`4226f7a9c`](https://togithub.com/carbon-design-system/carbon/commit/4226f7a9c)) ##### Housekeeping 🏠 - chore(release): v11.34.1 ([`22b28f5d0`](https://togithub.com/carbon-design-system/carbon/commit/22b28f5d0)) - chore(release): v11.34.0 ([#&carbon-design-system#8203;14282](https://togithub.com/carbon-design-system/carbon/issues/14282)) ([`42cf1b925`](https://togithub.com/carbon-design-system/carbon/commit/42cf1b925)) - chore(release): v11.34.0 ([`92d86277f`](https://togithub.com/carbon-design-system/carbon/commit/92d86277f)) ##### `@carbon/[email protected]` ##### Housekeeping 🏠 - chore(release): v11.34.1 ([`22b28f5d0`](https://togithub.com/carbon-design-system/carbon/commit/22b28f5d0)) - chore(release): v11.34.0 ([#&carbon-design-system#8203;14282](https://togithub.com/carbon-design-system/carbon/issues/14282)) ([`42cf1b925`](https://togithub.com/carbon-design-system/carbon/commit/42cf1b925)) - chore(release): v11.34.0 ([`92d86277f`](https://togithub.com/carbon-design-system/carbon/commit/92d86277f)) ##### `@carbon/[email protected]` ##### Housekeeping 🏠 - chore(release): v11.34.1 ([`22b28f5d0`](https://togithub.com/carbon-design-system/carbon/commit/22b28f5d0)) - chore(release): v11.34.0 ([#&carbon-design-system#8203;14282](https://togithub.com/carbon-design-system/carbon/issues/14282)) ([`42cf1b925`](https://togithub.com/carbon-design-system/carbon/commit/42cf1b925)) - chore(release): v11.34.0 ([`92d86277f`](https://togithub.com/carbon-design-system/carbon/commit/92d86277f)) ##### `@carbon/[email protected]` ##### Housekeeping 🏠 - chore(release): v11.34.1 ([`22b28f5d0`](https://togithub.com/carbon-design-system/carbon/commit/22b28f5d0)) - chore(release): v11.34.0 ([#&carbon-design-system#8203;14282](https://togithub.com/carbon-design-system/carbon/issues/14282)) ([`42cf1b925`](https://togithub.com/carbon-design-system/carbon/commit/42cf1b925)) - chore(release): v11.34.0 ([`92d86277f`](https://togithub.com/carbon-design-system/carbon/commit/92d86277f)) ##### `@carbon/[email protected]` ##### Housekeeping 🏠 - chore(release): v11.34.1 ([`22b28f5d0`](https://togithub.com/carbon-design-system/carbon/commit/22b28f5d0)) - chore(release): v11.34.0 ([#&carbon-design-system#8203;14282](https://togithub.com/carbon-design-system/carbon/issues/14282)) ([`42cf1b925`](https://togithub.com/carbon-design-system/carbon/commit/42cf1b925)) - chore(release): v11.34.0 ([`92d86277f`](https://togithub.com/carbon-design-system/carbon/commit/92d86277f)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/carbon-design-system/carbon-for-ibm-dotcom). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMzUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEzNS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding title to clear button in Search Component. The clear button now has the same type of of title that was created in the NumberInput component.
Changed
Testing / Reviewing