Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(project): add e2e test support with playwright #11302

Merged
merged 20 commits into from
May 2, 2022

Conversation

joshblack
Copy link
Contributor

@joshblack joshblack commented Apr 27, 2022

This PR adds an e2e testing harness for Visual Regression Testing with Percy & Playwright. It also removes support for Cypress and updates the VRT job in our CI workflow to use Playwright instead.

At a high-level, this change will run tests in CI that will report components in different themes to Percy which will then handle the image diff'ing. These tests are sharded in order to run in parallel and will correctly correspond to the same build for a PR.

Changelog

New

  • Add support for Playwright testing in the project
  • Add testing guide in testing.md

Changed

  • Update our VRT workflow to no longer call Cypress and instead call Playwright

Removed

  • Remove support for Cypress in packages/react

Testing / Reviewing

  • Verify that the two runs for the VRT job are reporting to the same percy build as reported in status checks
  • Verify that screenshots are correctly generated
  • Read through the testing guide, try out commands, see if it makes sense 👀

@netlify
Copy link

netlify bot commented Apr 27, 2022

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit c39c65f
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/62700a529e49500009060c5f
😎 Deploy Preview https://deploy-preview-11302--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 27, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit c39c65f
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/62700a52b27ce000086a70cb
😎 Deploy Preview https://deploy-preview-11302--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@joshblack joshblack marked this pull request as ready for review April 28, 2022 18:55
@joshblack joshblack requested a review from a team as a code owner April 28, 2022 18:55
@joshblack
Copy link
Contributor Author

FYI @carbon-design-system/developers-system for VRT testing!

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So excited for this one! 🎉

@joshblack
Copy link
Contributor Author

@jnm2377 would love to go over this on discord with you if you have a sec just to get feedback from you on the docs/setup/etc 👀

@jnm2377
Copy link
Contributor

jnm2377 commented Apr 28, 2022

@jnm2377 would love to go over this on discord with you if you have a sec just to get feedback from you on the docs/setup/etc 👀

@joshblack I can hop on disc rn

@joshblack joshblack requested a review from abbeyhrt May 2, 2022 16:14
@joshblack joshblack requested review from dakahn and removed request for abbeyhrt and dakahn May 2, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants