-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(OverflowMenu): size prop for v11 #10928
chore(OverflowMenu): size prop for v11 #10928
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 7c61979 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/62274344759fbf0007ec3a99 😎 Browse the preview: https://deploy-preview-10928--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 7c61979 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6227434431781300074525c7 😎 Browse the preview: https://deploy-preview-10928--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 6b8dc30 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/622632926321ac0007de441a 😎 Browse the preview: https://deploy-preview-10928--carbon-components-react.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 4fd30af 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/62263caeebc17e00080d6059 😎 Browse the preview: https://deploy-preview-10928--carbon-components-react.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 7c61979 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/62274344de2fab0008522a54 😎 Browse the preview: https://deploy-preview-10928--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Confirmed in old and new storybook ✅
One quick note for commit conventions, these types of changes could be considered a feat
vs a chore
since it's changing the Public API of this component. This totally gets tricky with feature flags but one way to think about it is since the commit is changing the API this would be a feat whereas a chore commit would not change the Public API
REF #10295
size
prop to only accept SM, MD, LG for v11 by adding a FeatureFlag.md
as a default for thesize
prop.xl
styles.Testing