Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(OverflowMenu): size prop for v11 #10928

Merged

Conversation

sstrubberg
Copy link
Member

REF #10295

  • Modified the size prop to only accept SM, MD, LG for v11 by adding a FeatureFlag.
  • Added md as a default for the size prop.
  • Added Controls functionality to Storybook story.
  • Removed deprecated xl styles.

Testing

  • Make sure everything is snappy in the v11 Storybook. Size controls should allow for SM, MD, and LG

@sstrubberg sstrubberg requested a review from a team as a code owner March 7, 2022 16:28
@sstrubberg sstrubberg requested review from joshblack and dakahn March 7, 2022 16:28
@netlify
Copy link

netlify bot commented Mar 7, 2022

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 7c61979

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/62274344759fbf0007ec3a99

😎 Browse the preview: https://deploy-preview-10928--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Mar 7, 2022

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 7c61979

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6227434431781300074525c7

😎 Browse the preview: https://deploy-preview-10928--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Mar 7, 2022

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 6b8dc30

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/622632926321ac0007de441a

😎 Browse the preview: https://deploy-preview-10928--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Mar 7, 2022

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 4fd30af

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/62263caeebc17e00080d6059

😎 Browse the preview: https://deploy-preview-10928--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Mar 7, 2022

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 7c61979

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/62274344de2fab0008522a54

😎 Browse the preview: https://deploy-preview-10928--carbon-components-react.netlify.app

Copy link
Contributor

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Confirmed in old and new storybook ✅

One quick note for commit conventions, these types of changes could be considered a feat vs a chore since it's changing the Public API of this component. This totally gets tricky with feature flags but one way to think about it is since the commit is changing the API this would be a feat whereas a chore commit would not change the Public API

@sstrubberg sstrubberg enabled auto-merge (squash) March 8, 2022 11:50
@sstrubberg sstrubberg merged commit 9659ff8 into carbon-design-system:main Mar 8, 2022
@sstrubberg sstrubberg deleted the chore/overflowmenu-size branch March 8, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants