Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(DatePickerInput): updated size prop #10912

Merged

Conversation

sstrubberg
Copy link
Member

@sstrubberg sstrubberg commented Mar 4, 2022

REF #10295

  • Modified the size prop to only accept SM, MD, LG.
  • Added md as a default for the size prop.
  • Added Controls functionality to Storybook story.
  • Removed xl size from styles.
  • Removed some old commented out code.

Testing

  • Make sure everything is snappy in the v11 Storybook. Size controls should allow for SM, MD, and LG

@sstrubberg sstrubberg requested a review from a team as a code owner March 4, 2022 16:36
@sstrubberg sstrubberg requested review from joshblack and dakahn March 4, 2022 16:36
@netlify
Copy link

netlify bot commented Mar 4, 2022

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 015255a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/62262d3c3c6386000782b0d4

😎 Browse the preview: https://deploy-preview-10912--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Mar 4, 2022

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 56c029e

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6222401f126a900008be91bd

😎 Browse the preview: https://deploy-preview-10912--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Mar 4, 2022

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 56c029e

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6222401f0fddb10007af9bbe

😎 Browse the preview: https://deploy-preview-10912--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Mar 4, 2022

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 015255a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/62262d3c0c06270007fe205a

😎 Browse the preview: https://deploy-preview-10912--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Mar 4, 2022

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 015255a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/62262d3c7f676d0008353ad4

😎 Browse the preview: https://deploy-preview-10912--carbon-components-react.netlify.app

@sstrubberg sstrubberg enabled auto-merge (squash) March 7, 2022 16:05
@sstrubberg sstrubberg merged commit 360d0b0 into carbon-design-system:main Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants