-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(IconSkeleton): move story to components #10835
Conversation
Would it be possible to have it be under the (The component itself looks great!) |
@tw15egan do you mean rename the component in v11 to |
I think aligning them naming-wise would be nice, we could just keep |
@tw15egan yeah, I can see how having the name switch would be more consistent. This PR was just intended as a quick doc fix so that people wouldn't be confused about what's being deprecated. I wasn't intending to introduce any changes. That said, we can ask the team what their thoughts are. Seems like the options are:
|
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 7036377 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6217bf4c2eef580007023eb9 😎 Browse the preview: https://deploy-preview-10835--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 7036377 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6217bf4cd4d4d400074c7449 😎 Browse the preview: https://deploy-preview-10835--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 7036377 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6217bf4ce9f90d000862d124 😎 Browse the preview: https://deploy-preview-10835--carbon-components-react.netlify.app |
No related issue, brought up in slack thread
Changelog
IconSkeleton
from the deprecated section to the components section.Testing / Reviewing
Review both the v10 and v11 deploy previews:
Icon
should still be in the deprecated section, butIconSkeleton
should no longer be included in those storiesIconSkeleton
should have it's own story now in the component section