Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(project): remove unstable prefix for applicable components #10768

Merged

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Feb 15, 2022

Closes #10767

Components that will be moving to "stable" in v11 should be exported from @carbon/react without the unstable prefix

Changelog

Changed

  • remove unstable prefix from components that will be stable in v11
  • update associated stories to no longer be experimental and include the prefix

Testing / Reviewing

  • Did I miss any? Or should something else remain unstable?
  • With this PR, we'll continue to have the following unstable components:
    • New Pagination
    • TreeView
    • ContextMenu

@tay1orjones tay1orjones requested a review from a team as a code owner February 15, 2022 22:46
@tay1orjones tay1orjones requested a review from dakahn February 15, 2022 22:46
@netlify
Copy link

netlify bot commented Feb 16, 2022

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 2391479

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/621e52eed6a6ea0008212b1e

😎 Browse the preview: https://deploy-preview-10768--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Feb 16, 2022

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 2391479

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/621e52ee3924880007965a5a

😎 Browse the preview: https://deploy-preview-10768--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Feb 16, 2022

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 2391479

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/621e52ed427c2c000762e44f

😎 Browse the preview: https://deploy-preview-10768--carbon-components-react.netlify.app

@joshblack
Copy link
Contributor

@tay1orjones I'm not 100% sure about context menu going to stable, is this something that we're tracking in the release? I'm just not aware of it and wanted to check-in

@tay1orjones
Copy link
Member Author

@joshblack Yeah, good question. I mistakenly thought everything delivered in #6830 and the few small follow up fixes we've seen since then put it in a spot of ready to move to stable, but it looks like there's some lingering pieces that need to be addressed.

Notably the wrapping behavior described in #7350 (comment), and some additional issues.

I'll update this PR placing Menu back under unstable.

@janhassel
Copy link
Member

@tay1orjones @joshblack Just chiming in. The two outstanding issues (#8073 and #8076) should be addressable without a breaking change. The third one tagged as context menu (#9426) actually requires no work on the Menu component.

I think Menu needs to be promoted to stable with v11 since the OverflowMenu/next implementation is based on it and requires MenuItem to be used instead of OverflowMenuItem. It also adds support for all related components:

  • MenuDivider
  • MenuGroup
  • MenuRadioGroup
  • MenuSelectableItem

Copy link
Contributor

@dakahn dakahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍🏾

@kodiakhq kodiakhq bot merged commit f0c64cf into carbon-design-system:main Mar 1, 2022
@tw15egan
Copy link
Collaborator

tw15egan commented Mar 1, 2022

I think this PR has caused an issue with the V11 storybook https://deploy-preview-10768--carbon-react-next.netlify.app/?path=/story/components-button--default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unstable prefix for components moving to stable
5 participants