Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): add missing v10 styles to number input #10706

Merged
merged 4 commits into from
Feb 14, 2022

Conversation

jnm2377
Copy link
Contributor

@jnm2377 jnm2377 commented Feb 11, 2022

Closes #10584
rel #10423

Changelog

Testing / Reviewing

  • review v11 deploy preview and make sure it matches v10 styles and is working as expected
  • review v11 story in firefox and make sure number input button dividers are visible
  • ensure tests pass

@jnm2377 jnm2377 requested a review from a team as a code owner February 11, 2022 07:40
@netlify
Copy link

netlify bot commented Feb 11, 2022

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 7546207

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/620acea3de792f000821342d

😎 Browse the preview: https://deploy-preview-10706--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Feb 11, 2022

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 7546207

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/620acea3467c7d0007b591d8

😎 Browse the preview: https://deploy-preview-10706--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Feb 11, 2022

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 7546207

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/620acea24dca7e0007222797

😎 Browse the preview: https://deploy-preview-10706--carbon-components-react.netlify.app/

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@jnm2377 jnm2377 merged commit 706020c into carbon-design-system:main Feb 14, 2022
@jnm2377 jnm2377 mentioned this pull request Feb 22, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit number-input styles
4 participants