-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(flexgrid): include flexgrid styles in @carbon/styles
and @carbon/react
#10666
fix(flexgrid): include flexgrid styles in @carbon/styles
and @carbon/react
#10666
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 4e1bf52 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6206a36f2c8c5f00085c0278 😎 Browse the preview: https://deploy-preview-10666--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 4e1bf52 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6206a36f4b0fb7000712bcc8 😎 Browse the preview: https://deploy-preview-10666--carbon-components-react.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 4e1bf52 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6206a36f1f2e3000074864f4 😎 Browse the preview: https://deploy-preview-10666--carbon-elements.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 thanks for getting this in so quickly!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TY!! lgtm
FlexGrid styles weren't being output from the new packages. I also had to move aspect ratio to it's own module to avoid duplicating it in both the css-grid and flex-grid styles
Changelog
New
@carbon/styles
and@carbon/react
Changed
@carbon/styles
Testing / Reviewing
View the FlexGrid "Responsive" story in the large breakpoint - the columns do not take up the full space because there is 16 columns now by default.
Modify storybook's
@use
to configure the new$flex-grid-columns
optioncarbon/packages/carbon-react/.storybook/styles.scss
Lines 7 to 8 in 83f414f