Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flexgrid): include flexgrid styles in @carbon/styles and @carbon/react #10666

Merged

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Feb 9, 2022

FlexGrid styles weren't being output from the new packages. I also had to move aspect ratio to it's own module to avoid duplicating it in both the css-grid and flex-grid styles

Changelog

New

  • include flexgrid styles in @carbon/styles and @carbon/react
  • add flexgrid stories to v11 storybook

Changed

  • move aspect ratio out of grid to it's own module within @carbon/styles

Testing / Reviewing

  • New v11 storybook should show FlexGrid stories rendered properly with styles.
  • Aspect ratio stories in both v10 and v11 storybook should be unaffected
  • To test 12 column configuration:
    • View the FlexGrid "Responsive" story in the large breakpoint - the columns do not take up the full space because there is 16 columns now by default.

      • image
    • Modify storybook's @use to configure the new $flex-grid-columns option

      @use '../index.scss' as styles;

    - @use '../index.scss' as styles
    + @use '../index.scss' as styles with (
    +   $flex-grid-columns: 12
    + );
    • View the FlexGrid "Responsive" story in the large breakpoint again - the columns now take up the full space because 12 columns have been configured
      • image

@tay1orjones tay1orjones self-assigned this Feb 9, 2022
@tay1orjones tay1orjones added this to the v11 Release Candidate 1 milestone Feb 9, 2022
@netlify
Copy link

netlify bot commented Feb 9, 2022

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 4e1bf52

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6206a36f2c8c5f00085c0278

😎 Browse the preview: https://deploy-preview-10666--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Feb 9, 2022

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: 4e1bf52

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6206a36f4b0fb7000712bcc8

😎 Browse the preview: https://deploy-preview-10666--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Feb 9, 2022

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 4e1bf52

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6206a36f1f2e3000074864f4

😎 Browse the preview: https://deploy-preview-10666--carbon-elements.netlify.app

@tay1orjones tay1orjones marked this pull request as ready for review February 9, 2022 22:58
@tay1orjones tay1orjones requested a review from a team as a code owner February 9, 2022 22:58
Copy link
Contributor

@jnm2377 jnm2377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 thanks for getting this in so quickly!

Copy link
Contributor

@aledavila aledavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!! lgtm

@jnm2377 jnm2377 enabled auto-merge (squash) February 11, 2022 17:57
@jnm2377 jnm2377 merged commit c2a62f9 into carbon-design-system:main Feb 11, 2022
@jnm2377 jnm2377 mentioned this pull request Feb 14, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants