-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(components): add HCM support to notificiation close icon #10639
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 56170c9 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61fc5459f54f320008493a2f 😎 Browse the preview: https://deploy-preview-10639--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 56170c9 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61fc5459c96dc700078e6ec5 😎 Browse the preview: https://deploy-preview-10639--carbon-components-react.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 56170c9 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61fc54597ba1ea0008fda7d4 😎 Browse the preview: https://deploy-preview-10639--carbon-elements.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having trouble getting a VM up and going, but this looks correct to me
Hmmm... I'm reviewing the HCM in white and black since the original issue seemed like it was in white HCM. It looks like the original issue wasn't actually fixed in the white HCM. When I look at the v11 live storybook, the issue is still present. And same for the v10 deploy preview for this PR. v11 storybook currentlyPR v10 deploy previewThat being said... I'm unsure how to proceed here with since the scope of this PR was to audit the styles and make sure they match, not necessarily fix the bug. Should this be a separate issue? What do you think? @abbeyhrt |
@jnm2377 Good question and great catch! Since these styles don't actually fix the problem, I'll re-open that issue and close this PR. I would rather resolve the issue and then just add whatever the solution is to both places. |
@abbeyhrt we may need to edit the @media screen and (-ms-high-contrast: white-on-black) https://developer.mozilla.org/en-US/docs/Web/CSS/@media/-ms-high-contrast |
Closes #10586
Closes #10585
REF #10199
Adds HCM for close icon in notification to
/components
as a part of the styles audit. Was previously added in/styles
.Testing / Reviewing
If you have a Windows computer, using HCM, check that notifications have an accessible close X icon.