Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react): added disabled prop to file uploader #10613

Merged
merged 10 commits into from
Feb 10, 2022
Merged

feat(react): added disabled prop to file uploader #10613

merged 10 commits into from
Feb 10, 2022

Conversation

TannerS
Copy link
Contributor

@TannerS TannerS commented Feb 1, 2022

Closes #

Not an issue but mentioned here https://ibm-cloudplatform.slack.com/archives/C0M053VPT/p1643384630118300

Changelog

New

Added disable prop to FileUploader and disabled styles to its label description and label text div elements

Testing / Reviewing

Verified in storybook, if unit test are needed, any feedback is appreciated

@TannerS TannerS requested a review from a team as a code owner February 1, 2022 23:39
@netlify
Copy link

netlify bot commented Feb 1, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 3576f17

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/62053551552ed90007d85317

😎 Browse the preview: https://deploy-preview-10613--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Feb 2, 2022

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 05e7d65

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61f9c4c348bcd0000899e963

😎 Browse the preview: https://deploy-preview-10613--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Feb 2, 2022

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 05e7d65

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61f9c4c35266ae0007035104

😎 Browse the preview: https://deploy-preview-10613--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Feb 2, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 3576f17

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6205355147fac30007cd85f0

😎 Browse the preview: https://deploy-preview-10613--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Feb 2, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 3576f17

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/62053551b5530a0007af6516

😎 Browse the preview: https://deploy-preview-10613--carbon-components-react.netlify.app

@TannerS TannerS requested a review from a team as a code owner February 2, 2022 02:17
dakahn
dakahn suggested changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@dakahn dakahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im getting a flash of incorrect styling on the dotted box when i mouse out on Firefox latest. Also I'm tapping in a designer here to make sure the styles are above board given we're not working off of a triaged issue ticket.

@TannerS
Copy link
Contributor Author

TannerS commented Feb 8, 2022 •
edited
Loading

Im getting a flash of incorrect styling on the dotted box when i mouse out on Firefox latest. Also I'm tapping in a designer here to make sure the styles are above board given we're not working off of a triaged issue ticket.

Hello, may i know what dotted line you are referring too? and let me know how I can help

@TannerS
Copy link
Contributor Author

TannerS commented Feb 8, 2022

@dakahn ^

@dakahn
Copy link
Contributor

dakahn commented Feb 9, 2022 •
edited
Loading

@TannerS
Peek 2022-02-08 18-05

the dotted line surrounding the drop zone for files. on mouse out theres a flash of incorrect styling

@TannerS
Copy link
Contributor Author

TannerS commented Feb 9, 2022

Hey @dakahn my code should have only touched the file uploader not the drop and drag one unless I made a mistake? I will review if my code somehow affected that however too!

@dakahn
Copy link
Contributor

dakahn commented Feb 9, 2022

@TannerS nope, you're right. disregard my comment. looks like its a bug in the stable version 🤦🏾

@TannerS
Copy link
Contributor Author

TannerS commented Feb 9, 2022

@dakahn got ya, thanks for that

@tay1orjones I hit re-review by mistake, just a fyi its asking you to re-approval

laurenmrice
laurenmrice approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for contributing! ✅

@kodiakhq kodiakhq bot merged commit 7310215 into carbon-design-system:main Feb 10, 2022
@jnm2377 jnm2377 mentioned this pull request Feb 10, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurenmrice laurenmrice laurenmrice approved these changes

@dakahn dakahn dakahn approved these changes

@tay1orjones tay1orjones Awaiting requested review from tay1orjones

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TannerS @dakahn @tay1orjones @laurenmrice