Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Button): make changes based on audit #10610

Merged
merged 8 commits into from
Feb 2, 2022
Merged

fix(Button): make changes based on audit #10610

merged 8 commits into from
Feb 2, 2022

Conversation

tw15egan
Copy link
Collaborator

@tw15egan tw15egan commented Feb 1, 2022

Refs #10409

Makes a few updates based on the Button audit

Changelog

New

  • Added a Playground story with "controls" enabled to validate the sizes

Changed

  • Updated type tokens
  • Updated Ghost button color tokens
  • Updated Danger Tertiary active background-color
  • Ensure icons render correctly

Testing / Reviewing

Go to the Button story in the carbon-next storybook and ensure it renders correctly and that the size control works.

@tw15egan tw15egan requested a review from a team as a code owner February 1, 2022 17:52
@netlify
Copy link

netlify bot commented Feb 1, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 6f0d082

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61fada3ad480c30007b002f8

😎 Browse the preview: https://deploy-preview-10610--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Feb 1, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 6f0d082

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61fada3a4d74700008856e47

😎 Browse the preview: https://deploy-preview-10610--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Feb 1, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 6f0d082

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61fada3a02870a0007860e71

😎 Browse the preview: https://deploy-preview-10610--carbon-components-react.netlify.app

aagonzales
aagonzales approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kodiakhq kodiakhq bot merged commit 1cb3a75 into carbon-design-system:main Feb 2, 2022
@jnm2377 jnm2377 mentioned this pull request Feb 10, 2022
Closed
22 tasks
@tw15egan tw15egan deleted the button-audit branch March 3, 2022 16:14
kennylam pushed a commit to kennylam/carbon that referenced this pull request Jul 30, 2024
@abdonrd
fix: replace className property to avoid override native property (ca…
399f569 
…rbon-design-system#10610)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakahn dakahn dakahn approved these changes

@aagonzales aagonzales aagonzales approved these changes

@tay1orjones tay1orjones tay1orjones approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tw15egan @tay1orjones @aagonzales @dakahn