-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(carbon-react): export style utilities, convert and z-index #10603
chore(carbon-react): export style utilities, convert and z-index #10603
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 1c84961 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61f98a23fd3fa4000872a376 😎 Browse the preview: https://deploy-preview-10603--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 1c84961 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61f98a2439f3880008c868d7 😎 Browse the preview: https://deploy-preview-10603--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 1c84961 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61f98a23b61ac3000729cc3f 😎 Browse the preview: https://deploy-preview-10603--carbon-components-react.netlify.app |
…bon-design-system#10603) ### Related Ticket(s) carbon-design-system/carbon-for-ibm-dotcom#10501 https://jsw.ibm.com/browse/ADCMS-3429 Upstream flatpickr tickets / PRs - flatpickr/flatpickr#2801 - flatpickr/flatpickr#2918 ### Description Fixes bugs with the date picker. Specifically we fix the reported bug where bluring from the input after a range selection would clear the first input. We then end up fixing a couple of other related bugs to get us back to a usable range input. Notably the usability issue reported wherin there ends up being a lot of month paging for far-past or far-future ranges to get a complete range is not addressed here, as that behavior is by design. Note that, as dicussed with @IgnacioBecerra, @kennylam and @andy-blum at office hours, the underlying [flatpickr](https://github.com/flatpickr/flatpickr) library is not seeing a concerted effort at maintenance. There are many bug reports piled up in their issue queue ([over 600 at time of writing](https://github.com/flatpickr/flatpickr/issues)) and not much commit activity or late. As a result, here I've updated to the latest tagged version of flatpickr (4.6.13), and then used [`yarn patch`](https://yarnpkg.com/cli/patch) to include necessary bug fixes. Upstream PR's and issues are linked above. ### Changelog **Changed** - date picker with range: fix a bug with date picker where bluring away from the first input after having populated a range value, would clear the first input - date picker with range: fix a bug where loosing focus from the calendar picker after having populated a range value, would clear the first input - date picker with range: fix a bug where clicking either input after having set a range would not show the selected range set in the calendar
Closes #10565
Updates
@carbon/react
to provide two utilities from the styles package,convert
andz-index
.Rather than open up the entire directory, only these select few have been included for now. The intent is for these to primarily be treated as internals, but we can provide additional utilities if/when we receive feedback that consuming projects are using them.
Changelog
New
convert
andz-index
utilities through@carbon/react
Testing / Reviewing