Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(TextInput): size audit #10589

Merged
merged 7 commits into from
Feb 2, 2022

Conversation

sstrubberg
Copy link
Member

@sstrubberg sstrubberg commented Jan 31, 2022

REF 10295

  • Added FeatureFlag ternary for TextInput size prop based on guidance provided by design. REF
  • Removed the defaultProps object moved them to default params. REF
  • Updated the public snappy and other tests because i moved the defaultProps.

Testing

  • Make sure TextInput is behaving correctly in the v11 & v10 storybooks and that size props are accurately reflected according to the design guidance.

@netlify
Copy link

netlify bot commented Jan 31, 2022

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 0bc2706

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61fb0aaadcab7700074ff4d1

😎 Browse the preview: https://deploy-preview-10589--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Jan 31, 2022

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 0bc2706

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61fb0aaae2ec4d000846dd87

😎 Browse the preview: https://deploy-preview-10589--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Jan 31, 2022

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 0bc2706

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61fb0aaa1253d0000843bc10

😎 Browse the preview: https://deploy-preview-10589--carbon-elements.netlify.app

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks the same 👍

@kodiakhq kodiakhq bot merged commit 4060572 into carbon-design-system:main Feb 2, 2022
@jnm2377 jnm2377 mentioned this pull request Feb 10, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants