Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(Toggle): add toggled knob #10550

Merged
merged 2 commits into from
Feb 9, 2022
Merged

docs(Toggle): add toggled knob #10550

merged 2 commits into from
Feb 9, 2022

Conversation

tw15egan
Copy link
Collaborator

Adds in a knob for toggled prop, first reported in Slack

Changelog

New

  • The toggled prop can now be changed via the toggled knob in the Toggle playground story

Testing / Reviewing

Ensure the knob works correctly

@tw15egan tw15egan requested a review from a team as a code owner January 28, 2022 14:54
@netlify
Copy link

netlify bot commented Jan 28, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 950d59e

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6203e188d27f740009459bc9

😎 Browse the preview: https://deploy-preview-10550--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Jan 28, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 950d59e

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6203e187cd7c7900081491a7

😎 Browse the preview: https://deploy-preview-10550--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 28, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 950d59e

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6203e18714455100085a0a2f

😎 Browse the preview: https://deploy-preview-10550--carbon-components-react.netlify.app

@kodiakhq kodiakhq bot merged commit b9c9920 into carbon-design-system:main Feb 9, 2022
@jnm2377 jnm2377 mentioned this pull request Feb 10, 2022
Closed
22 tasks
@tw15egan tw15egan deleted the toggled-knob branch March 3, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnm2377 jnm2377 jnm2377 approved these changes

@joshblack joshblack joshblack approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tw15egan @joshblack @jnm2377