Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): re-export type-classes #10489

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

jnm2377
Copy link
Contributor

@jnm2377 jnm2377 commented Jan 19, 2022

Ran into an issue migrating GTC where we needed a type mixin we forgot to re-export in the v11 styles package. This just adds it to the exports.

@mixin carbon--type-classes {
// Font families
@each $name, $value in $carbon--font-families {
.#{$prefix}--type-#{$name} {
font-family: $value;
}
}

internal slack thread for reviewers: https://ibm-studios.slack.com/archives/GCQ5R263T/p1642631874020800

Testing

  • make sure CI passes as expected

@jnm2377 jnm2377 requested a review from a team as a code owner January 19, 2022 22:50
@jnm2377 jnm2377 requested review from aledavila and abbeyhrt January 19, 2022 22:50
@jnm2377 jnm2377 changed the title fix(@carbon/styles: re-export type-classes fix(@carbon/styles): re-export type-classes Jan 19, 2022
@joshblack joshblack changed the title fix(@carbon/styles): re-export type-classes fix(styles): re-export type-classes Jan 19, 2022
@joshblack
Copy link
Contributor

joshblack commented Jan 19, 2022

Hope you don't mind, tweaked the title from fix(@carbon/styles) to fix(styles)

@netlify
Copy link

netlify bot commented Jan 19, 2022

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: f0f6432

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61e895acd311b70008960007

😎 Browse the preview: https://deploy-preview-10489--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Jan 19, 2022

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: f0f6432

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61e895acae7bc80007ecb6ce

😎 Browse the preview: https://deploy-preview-10489--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 19, 2022

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: f0f6432

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61e895acd115fa0007431e95

😎 Browse the preview: https://deploy-preview-10489--carbon-components-react.netlify.app

@jnm2377 jnm2377 merged commit 2cfa495 into carbon-design-system:main Jan 20, 2022
@abbeyhrt abbeyhrt mentioned this pull request Jan 27, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants