fix(ExpandableTile): fix devtool warning message for handleClick prop #10460
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
fix the warning message:
Warning: React does not recognize the
handleClick
prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercasehandleclick
instead. If you accidentally passed it from a parent component, remove it from the DOM element.at button
at ExpandableTile (webpack-internal:///./src/components/Tile/Tile.js:489:5)
at div
at div
at Container (webpack-internal:///./.storybook/Container.js:27:20)
at unboundStoryFn (webpack-internal:///../../node_modules/@storybook/store/dist/esm/prepareStory.js:265:12)
at ErrorBoundary (webpack-internal:///../../node_modules/@storybook/react/dist/esm/client/preview/render.js:120:5)
Changelog
New
Changed
Removed
Testing / Reviewing
install react dev tool chrom extension and make sure there is no warning for code like
<ExpandableTile handleClick={()=> console.log('i was clicked')} >
<div style={{ height: '200px' }}>Above the fold content here
<div style={{ height: '400px' }}>
Below the fold content here