Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Notifications): add close icon to HCM media queries #10447

Merged

Conversation

dakahn
Copy link
Contributor

@dakahn dakahn commented Jan 14, 2022

Closes #10199

Looks like we missed the close icons in our HCM pass. This covers them with our media queries.

Testing / Reviewing

In Windows, Activate High Contrast Mode in both black on white and white on black variants and see an accessible close X icon

@dakahn dakahn requested a review from a team as a code owner January 14, 2022 00:45
@dakahn dakahn requested review from tw15egan and aledavila January 14, 2022 00:45
@netlify
Copy link

netlify bot commented Jan 14, 2022

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 3209132

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61e738e4b462340007f9e886

😎 Browse the preview: https://deploy-preview-10447--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Jan 14, 2022

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 3209132

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61e738e45f58a200072bc239

😎 Browse the preview: https://deploy-preview-10447--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Jan 14, 2022

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 3209132

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61e738e4a1c9900007b549b0

😎 Browse the preview: https://deploy-preview-10447--carbon-elements.netlify.app

@joshblack joshblack requested a review from abbeyhrt January 14, 2022 21:37
@kodiakhq kodiakhq bot merged commit e2b8b30 into carbon-design-system:main Jan 18, 2022
@abbeyhrt abbeyhrt mentioned this pull request Jan 27, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: After high contrast with white is activated, the close icon is invisible
3 participants