Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fileuploaderdropcontainer): moved input out of label to fix a11y bug #10444

Merged

Conversation

TannerS
Copy link
Contributor

@TannerS TannerS commented Jan 13, 2022

Closes #

#10443

Changelog

Changed

Moved the input attribute outside the label

Testing / Reviewing

{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}

I tested it the same in the story book against the working copy and ran unit test. Far as I know, it behaves and works the same.

Before:
image

After:
image

@TannerS TannerS requested a review from a team as a code owner January 13, 2022 22:34
@TannerS TannerS requested review from joshblack and dakahn January 13, 2022 22:34
@netlify
Copy link

netlify bot commented Jan 13, 2022

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 47c23f9

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61ef08ce78ee8b0007600541

😎 Browse the preview: https://deploy-preview-10444--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Jan 13, 2022

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 47c23f9

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61ef08cddd08b00008ac66ae

😎 Browse the preview: https://deploy-preview-10444--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 13, 2022

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 47c23f9

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61ef08cd7dca520008ea9123

😎 Browse the preview: https://deploy-preview-10444--carbon-components-react.netlify.app

@joshblack
Copy link
Contributor

@TannerS could you share what violation is being addressed? I had a hard time telling from the screenshots and wanted to double-check 👀

@TannerS
Copy link
Contributor Author

TannerS commented Jan 18, 2022

@joshblack ya sure once I get back on a laptop, but if it helps, it's the only expanded one. I just forgot to click on more details. From what I gathered, it was something about the element appearing before the label and that was due to the element being inside the label element that had the assigned...I think it was the html forto? Or what ever it is that tells what element belongs to which label

@joshblack
Copy link
Contributor

@TannerS ah I see it now in the issue, sorry I didn't see it earlier!

@TannerS
Copy link
Contributor Author

TannerS commented Jan 18, 2022

@joshblack all good, let me know if u need a screen shot still. From my testing, it seems to behave the same even moving it outside the label but I wanted more eyes to be sure I'm not missing something

@kodiakhq kodiakhq bot merged commit d02f94d into carbon-design-system:main Jan 24, 2022
@TannerS TannerS deleted the tanner_fixFilerUploaderA11yIssue branch January 25, 2022 06:56
@abbeyhrt abbeyhrt mentioned this pull request Jan 27, 2022
22 tasks
metonym added a commit to carbon-design-system/carbon-components-svelte that referenced this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants