-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fileuploaderdropcontainer): moved input out of label to fix a11y bug #10444
fix(fileuploaderdropcontainer): moved input out of label to fix a11y bug #10444
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 47c23f9 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61ef08ce78ee8b0007600541 😎 Browse the preview: https://deploy-preview-10444--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 47c23f9 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61ef08cddd08b00008ac66ae 😎 Browse the preview: https://deploy-preview-10444--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 47c23f9 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61ef08cd7dca520008ea9123 😎 Browse the preview: https://deploy-preview-10444--carbon-components-react.netlify.app |
@TannerS could you share what violation is being addressed? I had a hard time telling from the screenshots and wanted to double-check 👀 |
@joshblack ya sure once I get back on a laptop, but if it helps, it's the only expanded one. I just forgot to click on more details. From what I gathered, it was something about the element appearing before the label and that was due to the element being inside the label element that had the assigned...I think it was the html forto? Or what ever it is that tells what element belongs to which label |
@TannerS ah I see it now in the issue, sorry I didn't see it earlier! |
@joshblack all good, let me know if u need a screen shot still. From my testing, it seems to behave the same even moving it outside the label but I wanted more eyes to be sure I'm not missing something |
Closes #
#10443
Changelog
Changed
Moved the input attribute outside the label
Testing / Reviewing
{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}
I tested it the same in the story book against the working copy and ran unit test. Far as I know, it behaves and works the same.
Before:
After: