Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): add default to tag-colors variable #10344

Merged
merged 4 commits into from
Jan 6, 2022
Merged

fix(components): add default to tag-colors variable #10344

merged 4 commits into from
Jan 6, 2022

Conversation

abbeyhrt
Copy link
Contributor

@abbeyhrt abbeyhrt commented Jan 5, 2022

Closes #10174

Adds @default to $tag-colors variable so it can be overridden downstream for custom themes.

Changelog

Changed

  • Defines $tag-colors as default so that it can be configured.

Testing / Reviewing

Verify that Tag colors are unaffected by this change.

@abbeyhrt abbeyhrt requested a review from a team as a code owner January 5, 2022 17:27
@netlify
Copy link

netlify bot commented Jan 5, 2022

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: b3fb609

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61d721c3def5d300072c7237

😎 Browse the preview: https://deploy-preview-10344--carbon-react-next.netlify.app

@abbeyhrt abbeyhrt changed the title Fix/tag colors fix(components): add default to tag-colors variable Jan 5, 2022
@netlify
Copy link

netlify bot commented Jan 5, 2022

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: ba650d3

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61d5d519a023cc0008a8575a

😎 Browse the preview: https://deploy-preview-10344--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 5, 2022

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: ba650d3

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61d5d519c6cd86000733236b

😎 Browse the preview: https://deploy-preview-10344--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Jan 5, 2022

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: b3fb609

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61d721c3708e4b0007742a68

😎 Browse the preview: https://deploy-preview-10344--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 5, 2022

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: b3fb609

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61d721c3eaae9b0008acf95e

😎 Browse the preview: https://deploy-preview-10344--carbon-components-react.netlify.app

@kodiakhq kodiakhq bot merged commit f6e81f3 into carbon-design-system:main Jan 6, 2022
@abbeyhrt abbeyhrt mentioned this pull request Jan 14, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Tag component doesn't respect custom theme colours
3 participants