Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint-config-carbon): add storybook config #10335

Merged
merged 13 commits into from
Jan 21, 2022
Merged

feat(eslint-config-carbon): add storybook config #10335

merged 13 commits into from
Jan 21, 2022

Conversation

joshblack
Copy link
Contributor

@joshblack joshblack commented Jan 4, 2022 •
edited
Loading

This PR introduces an ESLint configuration for eslint-plugin-storybook. This plugin enables a variety of rules for the style and/or convention of our storybook. These rules will make sure our stories are structured consistently for Component Story Format v3.

Changelog

New

  • Add eslint-plugin-storybook to our ESLint configuration and corresponding config

Changed

  • Updated files based on new rules, more often than not this fell into two categories:
    • Moving parameters.component to component
    • Updating stories to be PascalCase

Removed

Testing / Reviewing

  • Verify the plugin is running on story files (*.stories.js, *-story.js)

@netlify
Copy link

netlify bot commented Jan 4, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: da29a7a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61eadc5f3d9f2c000794fbf7

😎 Browse the preview: https://deploy-preview-10335--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Jan 4, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: da29a7a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61eadc5fc1bb4000097a3998

😎 Browse the preview: https://deploy-preview-10335--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 4, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: da29a7a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61eadc5f19aebd0007a8d0dc

😎 Browse the preview: https://deploy-preview-10335--carbon-components-react.netlify.app

@joshblack joshblack marked this pull request as ready for review January 18, 2022 17:14
@joshblack joshblack requested a review from a team as a code owner January 18, 2022 17:14
@joshblack joshblack requested review from abbeyhrt and dakahn January 18, 2022 17:14
abbeyhrt
abbeyhrt approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@abbeyhrt abbeyhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@dakahn
Copy link
Contributor

dakahn commented Jan 19, 2022

looks like we've got a storybook error about missing stories

@joshblack
Copy link
Contributor Author

@dakahn should be good to go now!

@kodiakhq kodiakhq bot merged commit 2774bd5 into carbon-design-system:main Jan 21, 2022
@abbeyhrt abbeyhrt mentioned this pull request Jan 27, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakahn dakahn dakahn approved these changes

@abbeyhrt abbeyhrt abbeyhrt approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshblack @dakahn @abbeyhrt