fix(react): add prop-types to package.json deps #10333
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in Slack (most likely related to the react-scripts v5 and webpack 5 updates) as an issue where our calls to
prop-types
was ambiguous since we do not list it as a dependency. This PR updates ourpackages/react
package to explicitly listprop-types
as a dependency.Changelog
New
Changed
prop-types
fromdevDependencies
todependencies
Removed
Testing / Reviewing