Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): add prop-types to package.json deps #10333

Merged

Conversation

joshblack
Copy link
Contributor

This came up in Slack (most likely related to the react-scripts v5 and webpack 5 updates) as an issue where our calls to prop-types was ambiguous since we do not list it as a dependency. This PR updates our packages/react package to explicitly list prop-types as a dependency.

Changelog

New

Changed

  • Move prop-types from devDependencies to dependencies

Removed

Testing / Reviewing

  • Verify CI passes as expected

@joshblack joshblack requested a review from a team as a code owner January 4, 2022 15:19
@netlify
Copy link

netlify bot commented Jan 4, 2022

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: e8b2cd9

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61d4ca31d6dac2000892a0ae

😎 Browse the preview: https://deploy-preview-10333--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Jan 4, 2022

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: e8b2cd9

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61d4ca3109af2600082f3eda

😎 Browse the preview: https://deploy-preview-10333--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 4, 2022

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: e8b2cd9

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61d4ca310333f1000776c0e6

😎 Browse the preview: https://deploy-preview-10333--carbon-components-react.netlify.app/

@kodiakhq kodiakhq bot merged commit ca8b011 into carbon-design-system:main Jan 4, 2022
@abbeyhrt abbeyhrt mentioned this pull request Jan 14, 2022
22 tasks
kennylam pushed a commit to kennylam/carbon that referenced this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants