Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(project): update examples to parcel 2 #10310

Merged
merged 1 commit into from
Dec 17, 2021
Merged

chore(project): update examples to parcel 2 #10310

merged 1 commit into from
Dec 17, 2021

Conversation

joshblack
Copy link
Contributor

This PR updates our examples to use parcel 2. Using parcel 1 was prohibiting us from moving to Yarn 3.1 as it had an install error due to a console message it emitted.

Changelog

New

Changed

  • Update parcel 1 examples to parcel 2

Removed

Testing / Reviewing

  • Verify the elements preview works as expected
  • Verify you can develop in an examples project that has been changed

@joshblack joshblack requested a review from a team as a code owner December 17, 2021 16:17
@netlify
Copy link

netlify bot commented Dec 17, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 7b30939

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61bcb82d5baf2e0008245dd0

😎 Browse the preview: https://deploy-preview-10310--carbon-react-next.netlify.app

@joshblack joshblack mentioned this pull request Dec 17, 2021
Merged
@netlify
Copy link

netlify bot commented Dec 17, 2021

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: 7b30939

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61bcb82d8d36bd00086c2af8

😎 Browse the preview: https://deploy-preview-10310--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Dec 17, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 7b30939

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61bcb82d3393ef0007f2e3b5

😎 Browse the preview: https://deploy-preview-10310--carbon-elements.netlify.app

tay1orjones
tay1orjones approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elements previews look solid 👍

@kodiakhq kodiakhq bot merged commit 334821f into carbon-design-system:main Dec 17, 2021
@abbeyhrt abbeyhrt mentioned this pull request Jan 14, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbeyhrt abbeyhrt abbeyhrt approved these changes

@tay1orjones tay1orjones tay1orjones approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshblack @tay1orjones @abbeyhrt