Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(project): update storybook to 6.4 #10290

Merged
merged 20 commits into from
Jan 6, 2022
Merged

chore(project): update storybook to 6.4 #10290

merged 20 commits into from
Jan 6, 2022

Conversation

joshblack
Copy link
Contributor

This PR updates our storybook to the latest version. It also updates our builders to use webpack5 for storybook along with adding in additional plugins to our carbon-react storybook

Changelog

New

  • Add storybook builders for webpack 5

Changed

  • Modify storybook config for carbon-react to include new plugins
  • Modify package dependencies to work with webpack 5

Removed

Testing / Reviewing

  • Verify deploy previews work as expected
  • Pull down locally
    • Verify development commands work as expected
    • Edit a stylesheet for both storybooks, verify the story updates as expected
    • Edit a story for both storybooks, verify the story updates as expected

@joshblack joshblack requested a review from a team as a code owner December 15, 2021 16:29
@netlify
Copy link

netlify bot commented Dec 15, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 51c4618

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61d72833ea72b700083d3a27

😎 Browse the preview: https://deploy-preview-10290--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Dec 15, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 51c4618

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61d728331eeacd00076861da

😎 Browse the preview: https://deploy-preview-10290--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Dec 15, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: 51c4618

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61d72833f63aaa00089803c3

😎 Browse the preview: https://deploy-preview-10290--carbon-components-react.netlify.app

joshblack and others added 10 commits December 15, 2021 17:20
@joshblack @abbeyhrt
Update packages/carbon-react/.storybook/theme.js
d777a20 
Co-authored-by: Abbey Hart <[email protected]>
@joshblack
Merge branch 'main' of github.com:carbon-design-system/carbon into ch…
95bbffb 
…ore/update-storybook-for-react-next
@joshblack
chore: check-in work
9e46659
@joshblack
Merge branch 'chore/update-storybook-for-react-next' of github.com:jo…
ef3798e 
…shblack/carbon into chore/update-storybook-for-react-next
@joshblack
Merge branch 'main' of github.com:carbon-design-system/carbon into ch…
5c44846 
…ore/update-storybook-for-react-next
@joshblack
chore: check-in work
d7460b0
@joshblack
Merge branch 'main' of github.com:carbon-design-system/carbon into ch…
05755ca 
…ore/update-storybook-for-react-next
@joshblack
chore(cypress): revert changes
7601931
@joshblack
chore(project): sync offline mirror and run format
ccfdc27
@joshblack
Merge branch 'main' of github.com:carbon-design-system/carbon into ch…
3fe2972 
…ore/update-storybook-for-react-next
@joshblack
Copy link
Contributor Author

bump @dakahn when you get a sec! Should be good to go now (🤞 )

@joshblack joshblack requested a review from a team as a code owner January 6, 2022 16:20
@kodiakhq kodiakhq bot merged commit b58900a into carbon-design-system:main Jan 6, 2022
@joshblack joshblack mentioned this pull request Jan 7, 2022
Closed
46 tasks
@abbeyhrt abbeyhrt mentioned this pull request Jan 14, 2022
Closed
22 tasks
kennylam added a commit to kennylam/carbon that referenced this pull request Jul 30, 2024
@kennylam
chore(checkbox): sync with @carbon/react v11 (carbon-design-system#…
7a69b0a 
…10290)

* chore(checkbox): sync with v11 React component

* chore(styles): fix checkbox styles for hideLabel and skeleton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakahn dakahn dakahn approved these changes

@abbeyhrt abbeyhrt abbeyhrt approved these changes

@aledavila aledavila Awaiting requested review from aledavila aledavila was automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshblack @abbeyhrt @dakahn