-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(DataTable): expand all header uses correct aria label #10288
fix(DataTable): expand all header uses correct aria label #10288
Conversation
❌ Deploy Preview for carbon-react-next failed. 🔨 Explore the source changes: b9e2f17 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61ba824260806b0007ccd247 |
❌ Deploy Preview for carbon-elements failed. 🔨 Explore the source changes: b9e2f17 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61ba8242f8f2c60008bec7ba |
❌ Deploy Preview for carbon-components-react failed. 🔨 Explore the source changes: abcdd8c 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61b91ea3cbad3e0008ff9d39 |
❌ Deploy Preview for carbon-components-react failed. 🔨 Explore the source changes: b9e2f17 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61ba8242c6039c0007341c33 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
* fix: add missed extenstions to on imports * fix: add missed extensions to settings imports --------- Co-authored-by: kennylam <[email protected]>
Closes #10254
Changelog
isExpanded
is trueTesting / Reviewing
button
in the dom > when it's collapsed, the aria label should now say "expand all", and vice versa. Compare to wrong label in current storybook.