Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DataTable): expand all header uses correct aria label #10288

Merged
merged 2 commits into from
Dec 16, 2021

Conversation

jnm2377
Copy link
Contributor

@jnm2377 jnm2377 commented Dec 14, 2021

Closes #10254

Changelog

  • applies "collapse all" text when isExpanded is true

Testing / Reviewing

  • view Expand All story > inspect the Expand All header button in the dom > when it's collapsed, the aria label should now say "expand all", and vice versa. Compare to wrong label in current storybook.

@jnm2377 jnm2377 requested a review from a team as a code owner December 14, 2021 22:45
@netlify
Copy link

netlify bot commented Dec 14, 2021

❌ Deploy Preview for carbon-react-next failed.

🔨 Explore the source changes: b9e2f17

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61ba824260806b0007ccd247

@netlify
Copy link

netlify bot commented Dec 14, 2021

❌ Deploy Preview for carbon-elements failed.

🔨 Explore the source changes: b9e2f17

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61ba8242f8f2c60008bec7ba

@netlify
Copy link

netlify bot commented Dec 14, 2021

❌ Deploy Preview for carbon-components-react failed.

🔨 Explore the source changes: abcdd8c

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61b91ea3cbad3e0008ff9d39

@netlify
Copy link

netlify bot commented Dec 14, 2021

❌ Deploy Preview for carbon-components-react failed.
Built without sensitive environment variables

🔨 Explore the source changes: b9e2f17

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61ba8242c6039c0007341c33

Copy link
Contributor

@abbeyhrt abbeyhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kodiakhq kodiakhq bot merged commit be73902 into carbon-design-system:main Dec 16, 2021
@abbeyhrt abbeyhrt mentioned this pull request Jan 14, 2022
22 tasks
kennylam added a commit to kennylam/carbon that referenced this pull request Jul 30, 2024
* fix: add missed extenstions to on imports

* fix: add missed extensions to settings imports

---------

Co-authored-by: kennylam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Expand all rows table header button shows the wrong aria-label
3 participants