Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(www): refactor insights pages and add packages #10282

Merged

Conversation

joshblack
Copy link
Contributor

This PR cleans up some of our www pages and adds support for packages. This is to make it easier to get details for a specific package (like component props) in a future PR. Here's a quick video of the changes

Screen.Recording.2021-12-13.at.12.11.06.mov

Changelog

New

  • Add new project support and test components like Flex, Box, and Text to help with building out pages

Changed

  • Update build task for @carbon/react to include _layer in output

Removed

Testing / Reviewing

  • Review as much or as little as you want! www is just a playground for project stats
  • If you want to run it locally, make sure you export GH_TOKEN=... with your GitHub Personal Access Token and run node www/tasks/collect.js to get all the GH data before running yarn develop in www

@joshblack joshblack requested a review from a team as a code owner December 13, 2021 18:15
@netlify
Copy link

netlify bot commented Dec 13, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 8f5503f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61ba58bec7fcc40007355d37

😎 Browse the preview: https://deploy-preview-10282--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Dec 13, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 8f5503f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61ba58be1e1537000766cab3

😎 Browse the preview: https://deploy-preview-10282--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Dec 13, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 8f5503f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61ba58be06b69f0008bfa367

😎 Browse the preview: https://deploy-preview-10282--carbon-components-react.netlify.app

@@ -0,0 +1,87 @@
/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain this whole file? This looks mainly like nonsense to me haha

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abbeyhrt thankfully this is a file that is just copy-pasted around the internet lol. You can find the implementation for murmur hash on GitHub, but effectively it's a specific type of hash that is quick and generally useful for looking things up based on id.

This can be nice if you need something that generally needs a "stable" id, whether that's for a URL or for looking things up from different parts of a system. In terms of why murmur hash, it could 100% be replaced with any other hash function and we'd be fine 😂 it's just the one I've used most recently.

Copy link
Contributor

@abbeyhrt abbeyhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell! I'm definitely curious about how murmer.js works!

@kodiakhq kodiakhq bot merged commit 95e4f85 into carbon-design-system:main Dec 15, 2021
@abbeyhrt abbeyhrt mentioned this pull request Jan 14, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants