-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(www): refactor insights pages and add packages #10282
feat(www): refactor insights pages and add packages #10282
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 8f5503f 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61ba58bec7fcc40007355d37 😎 Browse the preview: https://deploy-preview-10282--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 8f5503f 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61ba58be1e1537000766cab3 😎 Browse the preview: https://deploy-preview-10282--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 8f5503f 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61ba58be06b69f0008bfa367 😎 Browse the preview: https://deploy-preview-10282--carbon-components-react.netlify.app |
@@ -0,0 +1,87 @@ | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain this whole file? This looks mainly like nonsense to me haha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abbeyhrt thankfully this is a file that is just copy-pasted around the internet lol. You can find the implementation for murmur hash on GitHub, but effectively it's a specific type of hash that is quick and generally useful for looking things up based on id.
This can be nice if you need something that generally needs a "stable" id, whether that's for a URL or for looking things up from different parts of a system. In terms of why murmur hash, it could 100% be replaced with any other hash function and we'd be fine 😂 it's just the one I've used most recently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as far as I can tell! I'm definitely curious about how murmer.js
works!
This PR cleans up some of our www pages and adds support for packages. This is to make it easier to get details for a specific package (like component props) in a future PR. Here's a quick video of the changes
Screen.Recording.2021-12-13.at.12.11.06.mov
Changelog
New
Flex
,Box
, andText
to help with building out pagesChanged
@carbon/react
to include_layer
in outputRemoved
Testing / Reviewing
www
is just a playground for project statsexport GH_TOKEN=...
with your GitHub Personal Access Token and runnode www/tasks/collect.js
to get all the GH data before runningyarn develop
inwww