-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react): update Tabs API and delete next/Tab
#10225
feat(react): update Tabs API and delete next/Tab
#10225
Conversation
next/Tab
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 28fc7e6 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61afd177bcd7ac00098c635c 😎 Browse the preview: https://deploy-preview-10225--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 28fc7e6 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61afd177ecf5060007f0dc32 😎 Browse the preview: https://deploy-preview-10225--carbon-components-react.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 28fc7e6 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61afd177211dfd0008c872cc 😎 Browse the preview: https://deploy-preview-10225--carbon-elements.netlify.app |
I think you just need to update snapshots for our package entry points and you'll be good to go 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! One minor bit, but otherwise good to go 👍
Closes #10086
Closes #9988
REF #8487
Updates the API for Tabs from
to
This PR however does not implement horizontal scrolling. It felt like it was getting way too big and I thought that could be added after this is merged in.
Changelog
New
unstable_TabPanel
unstable_TabPanels
unstable_TabList
Changed
Tabs
, the component itself is now a context provider and does not contain the bulk of the logic, that is now inTabList
Removed
next/Tab
Tab will now be kept in context inTabs.js
instead of in its own directoryTesting / Reviewing
Pull down the PR and check to see how the component looks in the V11 storybook. Check to make sure that whatever functionality was available in Tabs or Tab (outside of scrolling) is still available in the new structure. There are some prop name changes but the same functionality should still exist.