Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RadioButton): fixes v11 disabled styles and explicitly includes disabled prop #10222

Merged
merged 3 commits into from
Dec 7, 2021

Conversation

jnm2377
Copy link
Contributor

@jnm2377 jnm2377 commented Dec 3, 2021

Closes #10099

Changelog

Looks like find & replace gone wrong. Updates radio btn styles in v11 to use proper disabled attribute selector.

Testing / Reviewing

  • Look at v11 radio btn story for disabled example. Should display styles properly now. Can compare to v10 radio btn disabled storybook example.

@jnm2377 jnm2377 requested a review from a team as a code owner December 3, 2021 22:07
@jnm2377 jnm2377 requested review from tay1orjones and dakahn December 3, 2021 22:07
@netlify
Copy link

netlify bot commented Dec 3, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 2346032

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61ae7e8fd67dc5000725e612

😎 Browse the preview: https://deploy-preview-10222--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Dec 3, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 2346032

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61ae7e8f450da70007e03c15

😎 Browse the preview: https://deploy-preview-10222--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Dec 3, 2021

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: 2346032

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61ae7e8fb2817d0008d37a36

😎 Browse the preview: https://deploy-preview-10222--carbon-components-react.netlify.app

@jnm2377 jnm2377 changed the title fix(@carbon/styles): radio button disabled styles fix(RadioButton): fixes v11 disabled styles and explicitly includes disabled prop Dec 6, 2021
@jnm2377 jnm2377 requested a review from tay1orjones December 6, 2021 20:32
Copy link
Contributor

@dakahn dakahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏄🏾

@jnm2377 jnm2377 merged commit 02e4246 into carbon-design-system:main Dec 7, 2021
kennylam pushed a commit to kennylam/carbon that referenced this pull request Jul 30, 2024
…em#10222)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [zone.js](https://togithub.com/angular/angular) ([changelog](https://togithub.com/angular/angular/blob/master/packages/zone.js/CHANGELOG.md)) | [`~0.12.0` -> `~0.13.0`](https://renovatebot.com/diffs/npm/zone.js/0.12.0/0.13.0) | [![age](https://badges.renovateapi.com/packages/npm/zone.js/0.13.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/zone.js/0.13.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/zone.js/0.13.0/compatibility-slim/0.12.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/zone.js/0.13.0/confidence-slim/0.12.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>angular/angular</summary>

### [`v0.13.0`](https://togithub.com/angular/angular/compare/zone.js-0.12.0...zone.js-0.13.0)

[Compare Source](https://togithub.com/angular/angular/compare/zone.js-0.12.0...zone.js-0.13.0)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Never, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/carbon-design-system/carbon-for-ibm-dotcom).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNjAuMCIsInVwZGF0ZWRJblZlciI6IjM0LjE2MC4wIn0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: next/RadioButton missing disabled styling
3 participants