Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v10.47.1 #10025

Closed
wants to merge 2 commits into from
Closed

Release v10.47.1 #10025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee6ee20
fix(Modal): add closeButtonLabel prop, add default value (#9998)
dakahn Oct 30, 2021
de5d85c
chore(release): v10.47.1
tay1orjones Nov 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/carbon-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@carbon/react",
"description": "React components for the Carbon Design System",
"version": "0.8.0",
"version": "0.8.1",
"license": "Apache-2.0",
"main": "lib/index.js",
"module": "es/index.js",
Expand Down Expand Up @@ -47,7 +47,7 @@
"@carbon/styles": "^0.8.0",
"@carbon/telemetry": "0.0.0-alpha.6",
"carbon-components": "^10.47.0",
"carbon-components-react": "^7.47.0",
"carbon-components-react": "^7.47.1",
"carbon-icons": "^7.0.7"
},
"devDependencies": {
Expand Down
3 changes: 3 additions & 0 deletions packages/react/__tests__/__snapshots__/PublicAPI-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3829,6 +3829,9 @@ Map {
"className": Object {
"type": "string",
},
"closeButtonLabel": Object {
"type": "string",
},
"danger": Object {
"type": "bool",
},
Expand Down
2 changes: 1 addition & 1 deletion packages/react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "carbon-components-react",
"description": "The Carbon Design System is IBM’s open-source design system for products and experiences.",
"version": "7.47.0",
"version": "7.47.1",
"license": "Apache-2.0",
"main": "lib/index.js",
"module": "es/index.js",
Expand Down
9 changes: 7 additions & 2 deletions packages/react/src/components/Modal/Modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,11 @@ export default class Modal extends Component {
*/
className: PropTypes.string,

/**
* Specify an label for the close button of the modal; defaults to close
*/
closeButtonLabel: PropTypes.string,

/**
* Specify whether the Modal is for dangerous actions
*/
Expand Down Expand Up @@ -384,6 +389,7 @@ export default class Modal extends Component {
shouldSubmitOnEnter, // eslint-disable-line
size,
hasScrollingContent,
closeButtonLabel,
preventCloseOnClickOutside, // eslint-disable-line
...other
} = this.props;
Expand Down Expand Up @@ -420,11 +426,10 @@ export default class Modal extends Component {
type="button"
onClick={onRequestClose}
title={ariaLabel ? ariaLabel : iconDescription}
aria-label={ariaLabel ? ariaLabel : iconDescription}
aria-label={closeButtonLabel ? closeButtonLabel : 'close'}
ref={this.button}>
<Close20
aria-hidden="true"
aria-label="close"
tabIndex="-1"
className={`${this.modalCloseButtonClass}__icon`}
/>
Expand Down
10 changes: 3 additions & 7 deletions packages/react/src/components/ModalWrapper/__snapshots__/ModalWrapper-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,19 +109,18 @@ exports[`ModalWrapper should render 1`] = `
Transactional Modal
</h3>
<button
aria-label="close"
className="bx--modal-close"
onClick={[Function]}
type="button"
>
<ForwardRef(Close20)
aria-hidden="true"
aria-label="close"
className="bx--modal-close__icon"
tabIndex="-1"
>
<Icon
aria-hidden="true"
aria-label="close"
className="bx--modal-close__icon"
fill="currentColor"
height={20}
Expand All @@ -132,15 +131,12 @@ exports[`ModalWrapper should render 1`] = `
xmlns="http://www.w3.org/2000/svg"
>
<svg
aria-hidden="true"
aria-label="close"
aria-hidden={true}
className="bx--modal-close__icon"
fill="currentColor"
focusable="true"
focusable="false"
height={20}
preserveAspectRatio="xMidYMid meet"
role="img"
tabIndex="-1"
viewBox="0 0 32 32"
width={20}
xmlns="http://www.w3.org/2000/svg"
Expand Down
4 changes: 2 additions & 2 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2014,7 +2014,7 @@ __metadata:
babel-preset-carbon: ^0.1.0
browserslist-config-carbon: ^10.6.1
carbon-components: ^10.47.0
carbon-components-react: ^7.47.0
carbon-components-react: ^7.47.1
carbon-icons: ^7.0.7
css-loader: ^5.2.4
fs-extra: ^10.0.0
Expand Down Expand Up @@ -10293,7 +10293,7 @@ __metadata:
languageName: node
linkType: hard

"carbon-components-react@^7.47.0, carbon-components-react@workspace:packages/react":
"carbon-components-react@^7.47.1, carbon-components-react@workspace:packages/react":
version: 0.0.0-use.local
resolution: "carbon-components-react@workspace:packages/react"
dependencies:
Expand Down