Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Add a new tag option #9670

Closed
1 task done
larahanlon2 opened this issue Sep 15, 2021 · 2 comments · Fixed by #9792
Closed
1 task done

[Feature Request]: Add a new tag option #9670

larahanlon2 opened this issue Sep 15, 2021 · 2 comments · Fixed by #9792
Labels
component: tags package: components carbon-components package: react carbon-components-react package: styles @carbon/styles proposal: accepted This request has gone through triaging and we are accepting PR's against it. type: enhancement 💡

Comments

@larahanlon2
Copy link

larahanlon2 commented Sep 15, 2021 •
edited by aagonzales
Loading

Summary

The IBM Research design team created a customized tag component for their latest web design release. We'd like to contribute back to Carbon/request an update to the core component so that other teams can use.

Details:

  1. The tag has a white background
  2. Black font-color
  3. 1px black stroke
  4. The tag is also clickable and have a grey-10 hover state

Example of specs:
Uploading Screen Shot 2021-09-15 at 4.34.25 PM.png…

Justification

We decided to organize our web content using tags and therefore needed to create a visual system to differentiate the different content types. When using a lot of tags in one area, we found the color fills of the Carbon default tags created too much visual clutter (or rainbow effect). The simple black and white version allowed us to simplify the overall design and focus on the content and interactivity.

Desired UX and success metrics

No response

Required functionality

The tag works the same as all other tags but has a hover state (grey-10).

Specific timeline issues / requests

No -- our devs already implemented the component here and here.

Available extra resources

We can provide the design and code

Code of Conduct
@snyk-bot snyk-bot mentioned this issue Sep 15, 2021
Open
@joshblack joshblack added proposal: open This request has gone through triaging. We're determining whether we take this on or not. and removed type: enhancement 💡 status: needs triage 🕵️‍♀️ labels Sep 15, 2021
@joshblack
Copy link
Contributor

cc @carbon-design-system/design

@aagonzales
Copy link
Member

Mike and I talked to Lara offline and we're good with adding in this variation.

@joshblack joshblack added proposal: accepted This request has gone through triaging and we are accepting PR's against it. component: tags package: components carbon-components package: react carbon-components-react package: styles @carbon/styles type: enhancement 💡 and removed proposal: open This request has gone through triaging. We're determining whether we take this on or not. labels Sep 15, 2021
@janhassel janhassel mentioned this issue Oct 4, 2021
Merged
@kodiakhq kodiakhq bot closed this as completed in #9792 Oct 4, 2021
kennylam added a commit to kennylam/carbon that referenced this issue Jul 30, 2024
@renovate @kennylam
@annawen1 @ariellalgilmore
chore(deps): update dependency tsickle to ~0.46.0 (carbon-design-syst…
bc9e288 
…em#9670)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: kennylam <[email protected]>
Co-authored-by: Anna Wen <[email protected]>
Co-authored-by: Ariella Gilmore <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: tags package: components carbon-components package: react carbon-components-react package: styles @carbon/styles proposal: accepted This request has gone through triaging and we are accepting PR's against it. type: enhancement 💡
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(tag): add outline variant janhassel/carbon
3 participants
@joshblack @aagonzales @larahanlon2