-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overflow menu alignment issue in Firefox #877
Comments
Couldn’t reproduce the issue, either in 60.x or 52.x ESR. Neither in the Carbon site or in our CodePen example. Here are some additional information which may help; Overflow menu code has |
I was able to reproduce the issue on another machine. Sometimes it would show on page load. Other times it would show on zoom in/out. We needed to implement a version of overflow menu that gets added to a specific dom element instead of to body. |
Thank you for explaining more - Wondering if above is what this issue is all about (we should change the title if it’s the case), or it’s a separate issue. If it’s the latter, could you please create a reduced case e.g. in CodePen? Thanks! |
Seems like this was addressed in #911 (comment) and #961 Feel free to reopen if you feel this is still an issue |
Detailed description
The overflow menu is not aligned horizontally with the button on Firefox. The issue can be seen on the "Vanilla JS" example displayed on http://carbondesignsystem.com/components/overflow-menu/code, and https://codepen.io/anon/pen/WyxMVb
Sometimes it appears to display with correct alignment, but if the user zooms in/out the menu becomes misaligned.
Reproduced on Firefox 60.0.1 and 52.8.0
The react version of the overflow menu does not seem to have this issue, though it appears to have a different implementation. Instead of using left/right dynamic positioning and being appended to the body, as is the case with the Vanilla JS version, it looks like it does not use dynamic positioning and is appended to the same div that contains the svg icon.
Overflow menu
Expect the overflow menu arrow to be aligned directly under the button/svg.
Firefox 60.0.1 and 52.8.0
Our app is using 8.19.5 ... The example above is using 9.0.2
Both look to have the issue.
Application has first major release in two weeks, the overflow menu is used throughout.
Additional information
The text was updated successfully, but these errors were encountered: