Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bidi support: The tick is inverted in Carbon Checkbox component with RTLCSS #7524

Closed
3 tasks done
DavidSCChen opened this issue Jan 11, 2021 · 0 comments · Fixed by #7564
Closed
3 tasks done

Bidi support: The tick is inverted in Carbon Checkbox component with RTLCSS #7524

DavidSCChen opened this issue Jan 11, 2021 · 0 comments · Fixed by #7564

Comments

@DavidSCChen
Copy link
Contributor

Bidi support: The tick is inverted in Carbon Checkbox component with RTLCSS.

What package(s) are you using?

  • carbon-components
  • carbon-components-react
  • @carbon/icons-react

Detailed description

Describe in detail the issue you're having.
While using the RTLCSS to address bidi layout issues, found that the tick in the checkbox is inverted, the tick should be kept from left to right.

Is this issue related to a specific component?
Checkbox

What did you expect to happen? What happened instead? What would you like to
see changed?
Expect the tick is from left to right that same as the LTR layout, but the tick became right to left with RTLCSS, and would like to see the tick from left to right while the CSS was processed by RTLCSS.

What browser are you working in?
Firefox 84.0.1 & Chrome 87.0.4280.141

What version of the Carbon Design System are you using?
10.26.0

Steps to reproduce the issue

  1. Create a Checkbox component
  2. Process the carbon-components.min.css with RTLCSS

Codesandbox in React:
https://codesandbox.io/s/webpack-react-rtlcss-carbon-checkbox-v4i6z

Additional information

  • Checkbox with RTLCSS:
    Carbon-check-1

  • Expected Checkbox:
    Carbon-check-2

DavidSCChen added a commit to DavidSCChen/carbon that referenced this issue Jan 14, 2021
…n-design-system#7524)

Fixed the tick orientation for checkbox component in bidi(RTL) layout by adding the RTLCSS value directives. (carbon-design-system#7524)
@kodiakhq kodiakhq bot closed this as completed in #7564 Jan 15, 2021
kodiakhq bot pushed a commit that referenced this issue Jan 15, 2021
#7564)

Fixed the tick orientation for checkbox component in bidi(RTL) layout by adding the RTLCSS value directives. (#7524)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant