Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SideNav] when the menu is expanded by hovering it, initially hidden page link won't work #6004

Closed
2 tasks done
mateim24 opened this issue May 4, 2020 · 0 comments · Fixed by #6043
Closed
2 tasks done

Comments

@mateim24
Copy link

mateim24 commented May 4, 2020

What package(s) are you using?

  • carbon-components
  • carbon-components-react

Detailed description

Describe in detail the issue you're having.

The issue appears on SideNav component when has the Rail prop.
When a user hover the left side menu and expands a SideNavMenu item that is collapsed and then clicks a page link (SideNavLink) the SideNavLink onClick handler should be called. Instead all SideNavMenu are automatically collapsed.

Is this issue related to a specific component?

SideNav

What did you expect to happen? What happened instead? What would you like to
see changed?

When a page link is clicked, its event handler should be called.

What browser are you working in?

The issue appears on Google Chrome Version 81.0.4044.129
on Firefox 75.0 it works

What version of the Carbon Design System are you using?

"carbon-components": "^10.11.2",
"carbon-components-react": "^7.11.3",
The issue appears also on the Carbon Components React Storybook

Steps to reproduce the issue

  1. Hover the SideNav menu;
  2. Expand a SideNavMenu;
  3. Click a page link;

When a page link is clicked all SideNavMenu items that are expanded will automatically collapse.

asudoh added a commit to asudoh/carbon-components that referenced this issue May 8, 2020
This changes fixes a logic in `<SideNav>` where it detects focus on a
nav item as side nav losing focus as a whole.

Fixes carbon-design-system#6004.
asudoh added a commit that referenced this issue May 12, 2020
This changes fixes a logic in `<SideNav>` where it detects focus on a
nav item as side nav losing focus as a whole.

Fixes #6004.
joshblack pushed a commit that referenced this issue May 13, 2020
This changes fixes a logic in `<SideNav>` where it detects focus on a
nav item as side nav losing focus as a whole.

Fixes #6004.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants