Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data table toolbar should be 32px height when table is short / compact #5420

Closed
vsnichols opened this issue Feb 21, 2020 · 0 comments · Fixed by #5479
Closed

Data table toolbar should be 32px height when table is short / compact #5420

vsnichols opened this issue Feb 21, 2020 · 0 comments · Fixed by #5479
Labels
component: data-table role: dev 🤖 type: bug 🐛

Comments

@vsnichols
Copy link

Data table toolbar should be 32px height when table is short / compact

When a user switches to short table height, the toolbar should switch to a short height as well. But in the Carbon react storybook the toolbar doesn’t update.

Actual:

Screen Shot 2020-02-21 at 7 50 04 AM

Expected:

Screen Shot 2020-02-21 at 3 56 49 PM
asudoh added a commit to asudoh/carbon-components that referenced this issue Feb 28, 2020
@asudoh
feat(DataTable): add small toolbar
fa9cae6 
This change adds small variant of table toolbar, used with
compact/short variant of table rows.

There were styles implemented for that presumably as part of original
`v10` work, but it was not used somehow.

Fixes carbon-design-system#5420.
@asudoh asudoh mentioned this issue Feb 28, 2020
Merged
asudoh added a commit that referenced this issue Mar 11, 2020
@asudoh
feat(DataTable): add small toolbar (#5479)
ef9c347 
This change adds small variant of table toolbar, used with
compact/short variant of table rows.

There were styles implemented for that presumably as part of original
`v10` work, but it was not used somehow.

Fixes #5420.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: data-table role: dev 🤖 type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(DataTable): add small toolbar asudoh/carbon-components
2 participants
@vsnichols @laurenmrice