Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProgressStep missing label #5113

Closed
nictownsend opened this issue Jan 21, 2020 · 6 comments
Closed

ProgressStep missing label #5113

nictownsend opened this issue Jan 21, 2020 · 6 comments

Comments

@nictownsend
Copy link
Contributor

ProgressStep is not setting/using a for the

Environment

Chrome Mac OS X
DAP chrome plugin
Jan2020 archive, IBM Accessibility January 2020 ruleset

Detailed description

What version of the Carbon Design System are you using?

Carbon Components React 7.9.2

What WCAG 2.1 checkpoint does the issue violate?

1.3.1 & 4.1.2

Steps to reproduce the issue

https://codesandbox.io/s/serene-galois-tpk91

Additional information

image

@joshblack
Copy link
Contributor

Hi there! 👋 I'm unable to reproduce this violation with the given codesandbox and running the IBM Accessibility WCAG 2.1 September 2019 ruleset, could you provide additional steps to help reproduce?

@nictownsend
Copy link
Contributor Author

Hi Josh, this is using Jan2020 archive, IBM Accessibility January 2020 ruleset

@joshblack
Copy link
Contributor

It seems like the node itself does have content that will be used as a label, this could be similar to #5112 in that it's a false positive with DAP. When looking at it, it does seem like the content is used as the label for the button when a screen reader focuses on it.

@tw15egan
Copy link
Collaborator

Does not seem to have any DAP violations when running this locally...

Screen Shot 2020-02-25 at 1 27 13 PM

@tw15egan
Copy link
Collaborator

Possibly due to this PR (#5125) and switching the use of div to button

@tw15egan
Copy link
Collaborator

Going to close this as resolved and will be fixed when 10.10.0 is released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants