Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<Button href="xyz"> missing label #5112

Closed
nictownsend opened this issue Jan 21, 2020 · 5 comments · Fixed by #5522
Closed

<Button href="xyz"> missing label #5112

nictownsend opened this issue Jan 21, 2020 · 5 comments · Fixed by #5522
Assignees
@joshblack
Labels
component: button status: needs more info type: a11y ♿

Comments

@nictownsend
Copy link
Contributor

Environment

Chrome Mac OS X
DAP chrome plugin
Jan2020 archive, IBM Accessibility January 2020 ruleset

Detailed description

What version of the Carbon Design System are you using?

Carbon Components React 7.9.2

What WCAG 2.1 checkpoint does the issue violate?

1.3.1 & 4.1.2

Steps to reproduce the issue

https://codesandbox.io/s/dreamy-goldberg-z2miy

Additional information

image
@joshblack
Copy link
Contributor

Hi there! 👋 I'm unable to reproduce this issue using the given codesandbox while running the IBM Accessibility WCAG 2.1 September 2019 ruleset. Could you provide some more details to reproduce?

@joshblack joshblack self-assigned this Jan 22, 2020
@nictownsend
Copy link
Contributor Author

Hi Josh, I used the Jan2020 archive in DAP

@tw15egan
Copy link
Collaborator

Since the anchor buttons have a role="button", looks like we need to add an aria-label to them. I can push up a quick fix

@tw15egan tw15egan mentioned this issue Jan 23, 2020
Closed
@joshblack
Copy link
Contributor

@tw15egan when looking at this with @dakahn it seems like a bug on DAP, am going through the process of filing an issue there 👍

@joshblack
Copy link
Contributor

Issued filed upstream at: https://ibm.biz/BdqDGA (can view behind IBM firewall)

@joshblack joshblack mentioned this issue Jan 30, 2020
Closed
@dakahn dakahn mentioned this issue Mar 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshblack joshblack

Labels
component: button status: needs more info type: a11y ♿
Projects
None yet
Milestone
No milestone
3 participants
@joshblack @tw15egan @nictownsend