[DragAndDropFileUploader]: "click to upload" not working

[abbeyhrt]

The drag and drop file uploader isn't fully functional in the react storybook. If you go here, you can drag and drop files to upload but the "click to upload" function doesn't seem to be working.

[Georgegriff]

glad someone else had this problem not just me, for now we'll just roll back our carbon upgrade, any idea what version this regressed in?

[Georgegriff]

Found it, aa46d5d#diff-ce0edbf1b641b96f453e0a6b6277bb31 Variable declared above the drop if statement, so when not dragging and dropping it fails

[asudoh]

Great catch @Georgegriff!

[zbeedatm]

Hi,
Can you please give more insight about how to proceed?
I tried:

1. Rolling back to previous release but problem still exist
2. Taking the fix (from: https://github.com/carbon-design-system/carbon/pull/4936/files) and applying it manually on the FileUploaderDropContainer.js under my installed node_moules but it didn't help too!

[asudoh]

@zbeedatm Strange that neither of the approach you described didn't work for you. I imagine your issue can be different from this issue. Would you want to re-create the reduced case, probably incorporating 1. above?

[zbeedatm]

Sure.
As I mentioned in #4933:

I had this sandbox that the browse functionality working on it:
https://codesandbox.io/s/fragrant-morning-267l5

I forked the same sandbox, but the browse functionality isn't working despite it still working on same version without upgrade:
https://codesandbox.io/s/heuristic-field-w2y75

A new one with the upgrade to 10.9.0:
https://codesandbox.io/s/zealous-dew-thll9

[asudoh]

At a glance of https://codesandbox.io/s/fragrant-morning-267l5 - What I see are tiles instead of file uploader. Thus I hoped a reduced case is prepared again, or probably an explanation is provided how to get to a file uploader there.

[zbeedatm]

Oh sorry, just press on the Import Project button
Can we continue our discussion on Slack? I sent you a message there...

[asudoh]

Thanks. As you know we have a channel for Carbon - Feel free to add more info there!

[asudoh]

Given https://codesandbox.io/s/fragrant-morning-267l5 has "carbon-components-react": "^7.7.4", I see it got a broken version. Changing ^ to ~ there seems to fix the problem.

[zbeedatm]

OK that's fixed it (I still don't know what is the different between "^" and "~" btw, but I'll read about it : )

Are you going to give a new release with a fix for this issue soon or had to wait for next release in a month? If it's not going to be during this weak, we will release our product with 7.7.4 instead of 10.9.0

[asudoh]

Unless you need a particular feature or fix from newer version of Carbon, I think it'll make sense to stay with an older version, especially if newer version breaks a thing.

[zbeedatm]

One more question, as I mentioned I tried taking the fix of this issue and inserting it manually to my local version of the FileDropContainer.js into node_modules folder, but when loading the application this fix didn't take effect!

Should this hack work? In general I know that it's not a good practice, but I just want to know that the option exists on the table.

Basically, from 10.9.0 I need the feature #4516

[asudoh]

Probably your code is overridden by NPM/Yarn install? I'd suggest maintaining a copy of Carbon code in your source tree instead.