-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Notification] Low contrast style bugs #4282
Comments
This change also makes inline notification's text color non-themeable for now, given the background color is non-themeable and making it themeable requires themeable component-specific token (or new global theme tokens). This stop-gap approach may be enough for short team because IIRC low-contrast notifications is there for a backword-compatibility reason. Refs carbon-design-system#4282.
was this solve in #4299? @aagonzales |
this is still blocked by compnent level theming right? for a workaround would we want to add a component level token or should we continue holding off until component level theming has been implemented? |
@emyarod Actually it looks like the low contrast notifications in the dark theme are showing correctly now in the storybook. I'm not sure when it was resolved. |
resolved in #7808 |
There are some style bugs with the low contrast variation of notification
Inline notifications in
White
andGray 10
themes need to add color border and remove the drop-shadow. See spec section belowGray 90 and Gray 100 low contrast notifications are completely wrong and should look like the specs in next section
Specs
Sketch file: https://ibm.box.com/s/wlqdd8ayfcvf4omy7616ldzs2elei9bv
To-be:
The text was updated successfully, but these errors were encountered: