Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[React Tooltip] carry over a11y fixes from Vanilla #3812

Closed
elizabethsjudd opened this issue Aug 23, 2019 · 2 comments · Fixed by #5282
Closed

[React Tooltip] carry over a11y fixes from Vanilla #3812

elizabethsjudd opened this issue Aug 23, 2019 · 2 comments · Fixed by #5282
Assignees
@emyarod
Labels
component: tooltip package: react carbon-components-react severity: 3 https://ibm.biz/carbon-severity type: a11y ♿

Comments

@elizabethsjudd
Copy link
Contributor

elizabethsjudd commented Aug 23, 2019 •
edited
Loading

Multiple updates have been made to the interactive tooltip for a11y. These changes should be carried over to React

#3148
#3476
@emyarod emyarod self-assigned this Aug 26, 2019
@emyarod emyarod mentioned this issue Aug 26, 2019
Closed
@tw15egan tw15egan added the package: react carbon-components-react label Aug 28, 2019
@emyarod
Copy link
Member

emyarod commented Sep 13, 2019

this should be closed by #3840 and #3842

@emyarod emyarod closed this as completed Sep 13, 2019
@emyarod
Copy link
Member

emyarod commented Sep 13, 2019

actually might need to take another look as this is related to interactive tooltip

@emyarod emyarod reopened this Sep 13, 2019
@aledavila aledavila added this to the Tooltip - A11y Project Team milestone Sep 30, 2019
@dakahn dakahn added priority: low severity: 3 https://ibm.biz/carbon-severity labels Sep 30, 2019
@dakahn dakahn removed this from the Tooltip - A11y Project Team milestone Sep 30, 2019
asudoh added a commit to asudoh/carbon-components that referenced this issue Feb 6, 2020
@asudoh
feat(Tooltip): add several ARIA attributes
512f22a 
This change adds several ARIA attributes along with `tooltipBodyId`
prop, so element relationships are better described.

This better aligns to the change made to vanilla earlier (carbon-design-system#3148 and

Fixes carbon-design-system#3812.
@asudoh asudoh mentioned this issue Feb 6, 2020
Merged
asudoh added a commit to asudoh/carbon-components that referenced this issue Feb 6, 2020
@asudoh
feat(Tooltip): add several ARIA attributes
c1fe58c 
This change adds several ARIA attributes along with `tooltipBodyId`
prop, so element relationships are better described.

This better aligns to the change made to vanilla earlier (carbon-design-system#3148 and

Fixes carbon-design-system#3812.
asudoh added a commit that referenced this issue Feb 6, 2020
@asudoh
feat(Tooltip): add several ARIA attributes (#5282)
45acec0 
This change adds several ARIA attributes along with `tooltipBodyId`
prop, so element relationships are better described.

This better aligns to the change made to vanilla earlier
(#3148 and #3476).

Fixes #3812.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emyarod emyarod

Labels
component: tooltip package: react carbon-components-react severity: 3 https://ibm.biz/carbon-severity type: a11y ♿
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(Tooltip): add several ARIA attributes asudoh/carbon-components
6 participants
@elizabethsjudd @mattrosno @emyarod @tw15egan @aledavila @dakahn