Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate the existing flags prop, add codemod migration #17243

Closed
5 tasks done
Tracked by #17080
2nikhiltom opened this issue Aug 22, 2024 · 0 comments · Fixed by #17266
Closed
5 tasks done
Tracked by #17080

Deprecate the existing flags prop, add codemod migration #17243

2nikhiltom opened this issue Aug 22, 2024 · 0 comments · Fixed by #17266
Assignees
@2nikhiltom
Labels
package: @carbon/react @carbon/react proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖 type: enhancement 💡 type: infrastructure 🤖 Issues relating to devops, tech debt, etc.

Comments

@2nikhiltom
Copy link
Contributor

2nikhiltom commented Aug 22, 2024 •
edited
Loading

  • Deprecate the existing flags prop
  • Write a codemod that converts the old flags format to the new boolean props
  • Add instructions for running the codemod to the flags deprecation warning message
  • Document the codemod in a new section on the feature flags .mdx page in storybook
  • Have codemod to remove old flags that are no longer needed, like enable-v11-release
@2nikhiltom 2nikhiltom mentioned this issue Aug 22, 2024
Closed
@2nikhiltom 2nikhiltom self-assigned this Aug 22, 2024
@tay1orjones tay1orjones changed the title Deprecate the existing flags prop. Deprecate the existing flags prop, add codemod migration Aug 23, 2024
@tay1orjones tay1orjones mentioned this issue Aug 23, 2024
Closed
@github-project-automation github-project-automation bot moved this to Triage in Roadmap Aug 23, 2024
@tay1orjones tay1orjones moved this to ⏱ Backlog in Design System Aug 23, 2024
@carbon-design-system carbon-design-system deleted a comment from github-actions bot Aug 23, 2024
@tay1orjones tay1orjones added the proposal: accepted This request has gone through triaging and we are accepting PR's against it. label Aug 23, 2024
@2nikhiltom 2nikhiltom mentioned this issue Aug 25, 2024
Merged
@sstrubberg sstrubberg removed this from Roadmap Sep 16, 2024
@github-project-automation github-project-automation bot moved this from ⏱ Backlog to ✅ Done in Design System Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@2nikhiltom 2nikhiltom

Labels
package: @carbon/react @carbon/react proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖 type: enhancement 💡 type: infrastructure 🤖 Issues relating to devops, tech debt, etc.
Projects
Design System
Archived in project
Milestone
No milestone
2 participants
@tay1orjones @2nikhiltom