Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert FeatureFlags' flags object prop to individual boolean props #17080

Closed
3 tasks done
tay1orjones opened this issue Jul 31, 2024 · 0 comments
Closed
3 tasks done
Assignees
Labels
planning: umbrella Umbrella issues, surfaced in Projects views role: dev 🤖
Milestone

Comments

@tay1orjones
Copy link
Member

tay1orjones commented Jul 31, 2024

The FeatureFlag component's flags prop currently takes an object shape

<FeatureFlags
flags={{
'enable-v12-tile-default-icons': true,
'enable-a-second-feature-flag': true,
}}>
<Tile />
</FeatureFlags>;

This is incompatible with IBM Telemetry. Instead, FeatureFlag should accept individual boolean props for each flag.

<FeatureFlags enableV12TileDefaultIcons enableASecondFeatureFlag>

Tasks

Preview Give feedback
  1. package: @carbon/react type: infrastructure 🤖
    riddhybansal
  2. package: @carbon/react proposal: accepted role: dev 🤖 type: enhancement 💡 type: infrastructure 🤖
    2nikhiltom
  3. area: typescript package: @carbon/react
    2nikhiltom

FAQ

  • Why can't we do this internally for consumers so they don't have to update or run a codemod?
    • Component/prop usage internal to the component is not collected by Telemetry. The boolean prop must be physically typed into the users source file in order for Telemetry to pick it up.
@tay1orjones tay1orjones moved this to ⏱ Backlog in Design System Jul 31, 2024
@tay1orjones tay1orjones added this to the 2024 Q3 milestone Jul 31, 2024
@tay1orjones tay1orjones changed the title Update FeatureFlags prop from object to individual props Update FeatureFlags' flags prop from object to individual props Jul 31, 2024
@tay1orjones tay1orjones changed the title Update FeatureFlags' flags prop from object to individual props Convert FeatureFlags' flags object prop to individual boolean props Jul 31, 2024
@2nikhiltom 2nikhiltom moved this from ⏱ Backlog to 🏗 In Progress in Design System Aug 22, 2024
@2nikhiltom 2nikhiltom moved this from 🏗 In Progress to 🚦 In Review in Design System Aug 25, 2024
@tay1orjones tay1orjones added the planning: umbrella Umbrella issues, surfaced in Projects views label Aug 28, 2024
@sstrubberg sstrubberg moved this from 🚦 In Review to 🏗 In Progress in Design System Sep 16, 2024
@sstrubberg sstrubberg moved this from 🏗 In Progress to 🪆 Needs Refined in Design System Sep 16, 2024
@github-project-automation github-project-automation bot moved this to Triage in Roadmap Sep 16, 2024
@sstrubberg sstrubberg moved this from Triage to Now 💫 in Roadmap Sep 16, 2024
@github-project-automation github-project-automation bot moved this from 🪆 Needs Refined to ✅ Done in Design System Oct 4, 2024
@github-project-automation github-project-automation bot moved this from Now 💫 to Completed 🚢 in Roadmap Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
planning: umbrella Umbrella issues, surfaced in Projects views role: dev 🤖
Projects
Archived in project
Archived in project
Development

No branches or pull requests

4 participants