Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♿ AVT3 ♿ Code Snippet - Screen reader accessibility is poor #1531

Closed
dakahn opened this issue Dec 5, 2018 · 3 comments
Closed

♿ AVT3 ♿ Code Snippet - Screen reader accessibility is poor #1531

dakahn opened this issue Dec 5, 2018 · 3 comments
Assignees
Labels
role: dev 🤖 type: a11y ♿ version: 10 Issues pertaining to Carbon v10

Comments

@dakahn
Copy link
Contributor

dakahn commented Dec 5, 2018

User tested with latest version of JAWS 2018, Windows 7, Chrome latest version

JAWS screen reader does not announce a code snippet as code and just reads it as text.

Note: this could be a larger problem with code blocks and screen readers in general and not specific to our implementation, but it's worth noting here for posterity's sake -- and perhaps work can be done to improve this situation

@snidersd
Copy link

@dakahn
AVT 3 issues found with macOS Mojave, Chrome and VoiceOver.
For the inline code snippet VO does not:

  • announce what the button is for. VO should announce that it is a "copy" button.
  • announce that the text is a code snippet.
  • announce "copied" after the button is pressed the first time. (note: copied is announced after the button is pressed twice).

For the single and multi-line code snippet VO:

  • Incorrectly announces that the code snippet is an editable text field.
  • Does not announce "copied" after the button is pressed the first time. (note: copied is announced after the button is pressed twice).

@dakahn dakahn changed the title ♿ AVT3 ♿ Code Snippet - JAWS does not indicate it is code ♿ AVT3 ♿ Code Snippet - Screen reader accessibility is poor Jan 28, 2019
@dakahn
Copy link
Contributor Author

dakahn commented Jan 28, 2019

Renaming this ticket and we can just use it to track the work on the code snippet more broadly for AVT3 compliance 💃

@carbon-bot
Copy link
Contributor

🎉 This issue has been resolved in version 9.82.16 🎉

The release is available on:

Your semantic-release bot 📦🚀

joshblack pushed a commit to joshblack/carbon that referenced this issue May 2, 2019
…n-system#1531)

* fix(DataTableSkeleton): Replace .keys with .map for IE11 compatibility

* chore(README): Add myself as a contributor

* fix(DataTableSkeleton): Use suggested syntax

* fix(DataTableSkeleton): use constant array length and access
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: dev 🤖 type: a11y ♿ version: 10 Issues pertaining to Carbon v10
Projects
None yet
Development

No branches or pull requests

3 participants