Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Carbon components]: Checkbox implementation differs from figma #14629

Closed
2 tasks done
korgan00 opened this issue Sep 11, 2023 · 3 comments
Closed
2 tasks done

[Carbon components]: Checkbox implementation differs from figma #14629

korgan00 opened this issue Sep 11, 2023 · 3 comments

Comments

@korgan00
Copy link

korgan00 commented Sep 11, 2023

Package

@carbon/react

Browser

No response

Package version

1.37

React version

No response

Description

Reference issue for web-components: carbon-design-system/carbon-for-ibm-dotcom#10910

I was trying to implement a form using radio buttons and checkboxes and I saw that they are so different between them and looking at the Figma file, I saw some differences between the implementation and the Figma library.

Element Figma Implementation
Padding between label-text and checkbox 8px (0.5rem) 6px (0.375rem)
Checkbox margins all: 0.125rem left: 0.1875rem the rest: 0.125rem
tag none (the min-height can be inferred if the checkbox is not absolute) min-height: 1.5rem; padding-top: 0.1875rem; padding-left: 1.25rem;
host margin-bottom none 0.25rem
screen capture Captura de pantalla 2023-09-05 a las 18 54 52 Captura de pantalla 2023-09-05 a las 19 02 54

Reproduction/example

https://react.carbondesignsystem.com/?path=/docs/components-checkbox--overview

Steps to reproduce

Use it

Suggested Severity

Severity 3 = User can complete task, and/or has a workaround within the user experience of a given component.

Application/PAL

IBM Quantum Learning

Code of Conduct

@tw15egan
Copy link
Collaborator

Is there a specific layout issue this is causing? cc @carbon-design-system/design can you confirm what changes need to be made to the React implementation

@korgan00
Copy link
Author

I have to create a multiple choice question that can be single answer (radio) or multiple answer (checkbox). I spent more time than expected trying to make them look the same because of this issue. Most of the implementation looks like patches on one side or the other.
There is a workaround as I suggested in the severity, but I think that the Design document and the implementation should look the same to prevent incoherences.
I forgot to create a link to the figma design

@tw15egan
Copy link
Collaborator

tw15egan commented Sep 12, 2023

Closing in favor of #14628

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants