Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web-components] Checkbox implementation differs from figma #10910

Closed
2 tasks done
korgan00 opened this issue Sep 5, 2023 · 3 comments
Closed
2 tasks done

[Web-components] Checkbox implementation differs from figma #10910

korgan00 opened this issue Sep 5, 2023 · 3 comments
Labels
bug Something isn't working dev Needs some dev work package: carbon web components

Comments

@korgan00
Copy link
Contributor

korgan00 commented Sep 5, 2023

Description

I was trying to implement a form using radio buttons and checkboxes and I saw that they are so different between them and looking at the Figma file, I saw some differences between the implementation and the Figma library.

Element Figma Implementation
Padding between label-text and checkbox 8px (0.5rem) 6px (0.375rem)
Checkbox margins all: 0.125rem left: 0.1875rem the rest: 0.125rem
tag none (the min-height can be inferred if the checkbox is not absolute) min-height: 1.5rem; padding-top: 0.1875rem; padding-left: 1.25rem;
host margin-bottom none 0.25rem
screen capture Captura de pantalla 2023-09-05 a las 18 54 52 Captura de pantalla 2023-09-05 a las 19 02 54

Component(s) impacted

Checkbox

Browser

No response

Carbon for IBM.com version

v2.0.1

Severity

Severity 3 = The problem is visible or noticeable to users but does not impede the usability or functionality. Affects minor functionality, has a workaround.

Application/website

IBM Quantum Learning

Package

@carbon/web-components

CodeSandbox example

https://web-components.carbondesignsystem.com/?path=/story/components-checkbox--default

Steps to reproduce the issue (if applicable)

No response

Release date (if applicable)

No response

Code of Conduct

@korgan00 korgan00 added bug Something isn't working dev Needs some dev work labels Sep 5, 2023
@kennylam kennylam moved this to Triage in Carbon for IBM.com Sep 11, 2023
@RichKummer
Copy link

Hey @korgan00 , same thing as #10911. Can you create this ticket in the carbon react repo?

@korgan00
Copy link
Contributor Author

korgan00 commented Sep 12, 2023

Looking at the react implementation, the differences in web-components are bigger. I think it is related to box-sizing.

@abdonrd
Copy link
Contributor

abdonrd commented Feb 5, 2024

Fixed here: carbon-design-system/carbon#14628

So updating the version should solve it here.

@andy-blum andy-blum closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2024
@github-project-automation github-project-automation bot moved this from Triage to Done in Carbon for IBM.com Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dev Needs some dev work package: carbon web components
Projects
Status: Done
Development

No branches or pull requests

5 participants