Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Actionable Notification (Warning Kind) has incorrect icon fill color. #11483

Closed
2 tasks done
Akshat55 opened this issue May 25, 2022 · 1 comment · Fixed by #11487
Closed
2 tasks done

[Bug]: Actionable Notification (Warning Kind) has incorrect icon fill color. #11483

Akshat55 opened this issue May 25, 2022 · 1 comment · Fixed by #11487
Assignees
@abbeyhrt
Labels
package: @carbon/react @carbon/react severity: 4 https://ibm.biz/carbon-severity type: bug 🐛

Comments

@Akshat55
Copy link
Contributor

Package

@carbon/styles

Browser

Chrome, Safari, Firefox, Edge

Package version

v1.2.0

Description

Actionable Notification with inline (true) & warning kind does not fill the SVG with the yellow (#f1c21b). Instead, there is a black fill.

Screenshots

image

Steps to reproduce

  1. Create actionable component
  2. Set inline prop to true
  3. Set kind to warning

Reproduction can be viewed at the following sandbox:
https://stackblitz.com/edit/github-neyzs9-y2jvmc?file=src%2FApp.jsx

Code of Conduct
@Akshat55
Copy link
Contributor Author

Low contrast works fine - highContrast does not.

image

@abbeyhrt abbeyhrt mentioned this issue May 25, 2022
Merged
@joshblack joshblack moved this to 🏗 In Progress in Design System May 26, 2022
@kodiakhq kodiakhq bot closed this as completed in #11487 May 31, 2022
Repository owner moved this from 🏗 In Progress to ✅ Done in Design System May 31, 2022
kennylam pushed a commit to kennylam/carbon that referenced this issue Jul 30, 2024
@sangeethababu9223
fix(datatable): search not working with uppercase characters in query (…
2b0274c 
…carbon-design-system#11493)

### Related Ticket(s)

Closes carbon-design-system#11483

### Description

Search is not working as expected with uppercase characters in query string.

### Changelog

**Changed**

- Updated the search logic to convert the query string as well as the main string to lowercase and then compare.

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abbeyhrt abbeyhrt

Labels
package: @carbon/react @carbon/react severity: 4 https://ibm.biz/carbon-severity type: bug 🐛
Projects
Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(styles): remove black fill for inline actionable notification icon abbeyhrt/my-carbon-fork-1
3 participants
@sstrubberg @abbeyhrt @Akshat55