Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: HeaderMenu with isCurrentPage does not have a pointer cursor #10109

Closed
2 tasks done
metonym opened this issue Nov 12, 2021 · 1 comment · Fixed by #12265
Closed
2 tasks done

[Bug]: HeaderMenu with isCurrentPage does not have a pointer cursor #10109

metonym opened this issue Nov 12, 2021 · 1 comment · Fixed by #12265
Labels
component: ui-shell good first issue 👋 Used by GitHub to elevate contribution opportunities package: react carbon-components-react severity: 3 https://ibm.biz/carbon-severity type: bug 🐛

Comments

@metonym
Copy link
Collaborator

metonym commented Nov 12, 2021

Package

carbon-components-react

Browser

Chrome

Package version

v10.48.0

Description

I'm expecting to see a "pointer" cursor when hovering over a <HeaderMenu isCurrentPage>.

Instead, it shows the default cursor, leading me to believe that it is not interactive.

CodeSandbox example

N/A

Steps to reproduce

Visit https://react.carbondesignsystem.com/?path=/story/components-ui-shell--header-base-w-navigation

carbon-menu.mov

Code of Conduct
@tay1orjones tay1orjones added severity: 3 https://ibm.biz/carbon-severity component: ui-shell package: react carbon-components-react and removed status: needs triage 🕵️‍♀️ labels Nov 14, 2021
@tay1orjones
Copy link
Member

tay1orjones commented Nov 14, 2021 •
edited
Loading

Thanks for the report @metonym. I think this was a small detail missed in #9785

@tay1orjones tay1orjones moved this to ⏱ Backlog in Design System Nov 14, 2021
@tay1orjones tay1orjones assigned dakahn and unassigned dakahn Nov 14, 2021
@jnm2377 jnm2377 added the good first issue 👋 Used by GitHub to elevate contribution opportunities label Aug 15, 2022
hannelevaltanen added a commit to hannelevaltanen/carbon that referenced this issue Oct 9, 2022
@hannelevaltanen
fix(HeaderMenu): menu-item--current instead of submenu--current (carb…
e57515f 
…on-design-system#10109)
@hannelevaltanen hannelevaltanen mentioned this issue Oct 9, 2022
Merged
sstrubberg pushed a commit that referenced this issue Oct 17, 2022
@hannelevaltanen
fix(HeaderMenu): fix HeaderMenu with isCurrentPage to have a pointer …
268decf 
…cursor (#10109) (#12265)

* fix(HeaderMenu): menu-item--current instead of submenu--current (#10109)

* fix(HeaderMenu): add isCurrentPage for HeaderMenu story

* fix(HeaderMenu): update tests for HeaderMenu to use menu-item--current

* fix(HeaderMenu): remove duplicated styles for current page HeaderMenu
Repository owner moved this from ⏱ Backlog to ✅ Done in Design System Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: ui-shell good first issue 👋 Used by GitHub to elevate contribution opportunities package: react carbon-components-react severity: 3 https://ibm.biz/carbon-severity type: bug 🐛
Projects
Design System
Archived in project
Milestone
No milestone
4 participants
@tay1orjones @metonym @jnm2377 @dakahn